public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Huang Rui <ray.huang@amd.com>,
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Perry Yuan <perry.yuan@amd.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	Mario Limonciello <superm1@kernel.org>
Subject: Re: [PATCH v4 1/2] cpufreq/amd-pstate: Pass the policy to amd_pstate_update()
Date: Thu, 2 Apr 2026 08:52:47 -0500	[thread overview]
Message-ID: <178f3a55-6faf-4070-9e38-85c547b27a03@amd.com> (raw)
In-Reply-To: <4bwfgnjiywkm4dyslhzmk6lvar3a6rhvtcyyruc7okybckuwuf@mkdc5dlconx4>



On 4/2/26 01:39, Viresh Kumar wrote:
> On 02-04-26, 12:07, Viresh Kumar wrote:
>> On 16-03-26, 08:18, K Prateek Nayak wrote:
>>> All callers of amd_pstate_update() already have a reference to the
>>> cpufreq_policy object.
>>>
>>> Pass the entire policy object and grab the cpudata using
>>> "policy->driver_data" instead of passing the cpudata and unnecessarily
>>> grabbing another read-side reference to the cpufreq policy object when
>>> it is already available in the caller.
>>>
>>> No functional changes intended.
>>>
>>> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>>> Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
>>> ---
>>> changelog v3..v4:
>>>
>>> o No changes.
>>> ---
>>>   drivers/cpufreq/amd-pstate.c | 11 ++++-------
>>>   1 file changed, 4 insertions(+), 7 deletions(-)
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Oops, I already Acked it once :)
> 
> It is ready for Rafael to pick now.
> 

I'm sending an amd-pstate PR later today after some more testing.

I'll pick this up in my PR that goes to Rafael.

  reply	other threads:[~2026-04-02 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  8:18 [PATCH v4 0/2] cpufreq/amd-pstate: Prevent scheduling when atomic on PREEMPT_RT K Prateek Nayak
2026-03-16  8:18 ` [PATCH v4 1/2] cpufreq/amd-pstate: Pass the policy to amd_pstate_update() K Prateek Nayak
2026-03-26 12:03   ` Gautham R. Shenoy
2026-04-02  6:37   ` Viresh Kumar
2026-04-02  6:39     ` Viresh Kumar
2026-04-02 13:52       ` Mario Limonciello [this message]
2026-04-03  4:06         ` K Prateek Nayak
2026-03-16  8:18 ` [PATCH v4 2/2] cpufreq: Pass the policy to cpufreq_driver->adjust_perf() K Prateek Nayak
2026-03-16 10:59   ` Gary Guo
2026-03-26 12:04   ` Gautham R. Shenoy
2026-03-26 13:16   ` Zhongqiu Han
2026-04-02  6:52   ` Zhongqiu Han
2026-04-02  6:00 ` [PATCH v4 0/2] cpufreq/amd-pstate: Prevent scheduling when atomic on PREEMPT_RT K Prateek Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178f3a55-6faf-4070-9e38-85c547b27a03@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=gautham.shenoy@amd.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=perry.yuan@amd.com \
    --cc=rafael@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=rostedt@goodmis.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=superm1@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox