Re: [PATCH v11 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/06/2025 07:12, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
> 
> IPQ5018 tsens should not use qcom,tsens-v1 as fallback since it has no RPM
> and, as such, deviates from the standard v1 init routine in the driver.
> So let's make qcom,ipq5018-tsens a standalone compatible in the bindings.
> 
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
>  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 5 ++++-

You just added it recently with the fallback (in v9 of this patchset)
and now remove it?

And what does it mean it has no RPM? How does it affect the driver? Does
fallback work or not?


>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 0e653bbe9884953b58c4d8569b8d096db47fd54f..73d722bda8adc2c930edfc3373e6011f19c7c491 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -36,10 +36,13 @@ properties:
>                - qcom,msm8974-tsens
>            - const: qcom,tsens-v0_1
>  
> +      - description: v1 of TSENS

So that's still v1... I don't understand.

> +        enum:
> +          - qcom,ipq5018-tsens
> +
>        - description: v1 of TSENS
>          items:
>            - enum:
> -              - qcom,ipq5018-tsens
>                - qcom,msm8937-tsens
>                - qcom,msm8956-tsens
>                - qcom,msm8976-tsens
> 


Best regards,
Krzysztof