From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org
Subject: [PATCH] ACPI / PM: Fix build problem when CONFIG_ACPI or CONFIG_PM is not set
Date: Fri, 16 Nov 2012 00:12:54 +0100 [thread overview]
Message-ID: <1812129.dYO2ty2NF7@vostro.rjw.lan> (raw)
In-Reply-To: <50a44947.moPp4aPN29u1CjRu%fengguang.wu@intel.com>
On Thursday, November 15, 2012 09:45:43 AM kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git acpi-dev-pm
> head: 99926a8cd36b6088448fec41aed4a3b5b05b3679
> commit: e5cc8ef31267317f3e177415c84e3f3602e5bfc9 [9/10] ACPI / PM: Provide ACPI PM callback routines for subsystems
> config: make ARCH=arm tegra_defconfig
>
> All error/warnings:
>
> In file included from drivers/pci/irq.c:7:0:
> include/linux/acpi.h: In function 'acpi_dev_pm_attach':
> include/linux/acpi.h:463:68: error: 'ENODEV' undeclared (first use in this function)
> include/linux/acpi.h:463:68: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +463 +/ENODEV include/linux/acpi.h
>
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 457 #endif
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 458
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 459 #if defined(CONFIG_ACPI) && defined(CONFIG_PM)
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 460 int acpi_dev_pm_attach(struct device *dev);
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 461 int acpi_dev_pm_detach(struct device *dev);
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 462 #else
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 @463 static inline int acpi_dev_pm_attach(struct device *dev) { return -ENODEV; }
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 464 static inline void acpi_dev_pm_detach(struct device *dev) {}
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 465 #endif
> e5cc8ef3 Rafael J. Wysocki 2012-11-02 466
>
> ---
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Subject: ACPI / PM: Fix build problem when CONFIG_ACPI or CONFIG_PM is not set
Commit e5cc8ef (ACPI / PM: Provide ACPI PM callback routines for
subsystems) introduced a build problem occuring if CONFIG_ACPI is
unset or CONFIG_PM is unset and errno.h is not included before
acpi.h, because in that case ENODEV used in acpi.h is undefined.
Fix the issue by making acpi.h include errno.h.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
On top of the current linux-pm.git/acpi-dev-pm.
---
include/linux/acpi.h | 1 +
1 file changed, 1 insertion(+)
Index: linux-pm/include/linux/acpi.h
===================================================================
--- linux-pm.orig/include/linux/acpi.h
+++ linux-pm/include/linux/acpi.h
@@ -25,6 +25,7 @@
#ifndef _LINUX_ACPI_H
#define _LINUX_ACPI_H
+#include <linux/errno.h>
#include <linux/ioport.h> /* for struct resource */
#ifdef CONFIG_ACPI
prev parent reply other threads:[~2012-11-15 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 1:45 [pm:acpi-dev-pm 9/10] include/linux/acpi.h:463:68: error: 'ENODEV' undeclared kbuild test robot
2012-11-15 23:12 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1812129.dYO2ty2NF7@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=fengguang.wu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox