From: Arjan van de Ven <arjan@linux.intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: "artem.bityutskiy@linux.intel.com"
<artem.bityutskiy@linux.intel.com>,
"rafael@kernel.org" <rafael@kernel.org>
Subject: Re: [PATCH 1/4] intel_idle: refactor state->enter manipulation into its own function
Date: Wed, 7 Jun 2023 07:08:12 -0700 [thread overview]
Message-ID: <183ea3e9-87a5-c686-a135-a0eb5dd4dad8@linux.intel.com> (raw)
In-Reply-To: <0626374836562df9925e440fd8dd7444d36f7025.camel@intel.com>
On 6/7/2023 12:34 AM, Zhang, Rui wrote:
> Just one minor comment.
>
> On Mon, 2023-06-05 at 15:47 +0000, arjan@linux.intel.com wrote:
>>
>>
>> +static void state_update_enter_method(struct cpuidle_state *state,
>> int cstate)
>> +{
>> + if (state->flags & CPUIDLE_FLAG_INIT_XSTATE) {
>> + /*
>> + * Combining with XSTATE with IBRS or IRQ_ENABLE
>> flags
>> + * is not currently supported but this driver.
>
> s/but/by?
> seems like a typo in the original commit.
this commit is a strict move of the existing code into a function, with zero changes
I would prefer to keep it that way obviously.
If someone wants to fix up spelling in comments that should be some completely independent commit
next prev parent reply other threads:[~2023-06-07 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 15:47 [PATCH 0/4 v2] Add support for running in VM guests to intel_idle arjan
2023-06-05 15:47 ` [PATCH 1/4] intel_idle: refactor state->enter manipulation into its own function arjan
2023-06-07 7:34 ` Zhang, Rui
2023-06-07 14:08 ` Arjan van de Ven [this message]
2023-06-05 15:47 ` [PATCH 2/4] intel_idle: clean up the (new) state_update_enter_method function arjan
2023-06-12 18:09 ` Rafael J. Wysocki
2023-06-05 15:47 ` [PATCH 3/4] intel_idle: Add support for using intel_idle in a VM guest using just hlt arjan
2023-06-12 18:05 ` Rafael J. Wysocki
2023-06-12 18:07 ` Arjan van de Ven
2023-06-15 17:46 ` Rafael J. Wysocki
2023-07-17 8:34 ` Xiaoyao Li
2023-07-17 12:58 ` Rafael J. Wysocki
2023-07-17 14:07 ` Arjan van de Ven
2023-07-17 14:51 ` Rafael J. Wysocki
2023-07-17 14:53 ` Arjan van de Ven
2023-06-05 15:47 ` [PATCH 4/4] intel_idle: Add a "Long HLT" C1 state for the VM guest mode arjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183ea3e9-87a5-c686-a135-a0eb5dd4dad8@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).