Re: [PATCH v3 04/20] media: synopsys: hdmirx: replace macros with bitfield variants

Heiko Stuebner
2025-08-27T07:07:40Z

Am Montag, 25. August 2025, 10:28:24 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli:
> The era of hand-rolled HIWORD_UPDATE macros is over, at least for those
> drivers that use constant masks.
>
> Replace the UPDATE macro with bitfield.h's FIELD_PREP, to give us
> additional error checking.
>
> Also, replace the HIWORD_UPDATE macro at the same time with the new
> FIELD_PREP_WM16 macro in hw_bitfield.h, which also gives us additional
> error checking.
>
> The UPDATE/HIWORD_UPDATE macros are left as wrappers around the
> replacement macros, in order to not rock the boat too much, and keep the
> changes easy to review.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>