Re: [PATCH v3 09/20] phy: rockchip-samsung-dcphy: switch to FIELD_PREP_WM16 macro

Heiko Stuebner
2025-08-27T07:28:13Z

Am Montag, 25. August 2025, 10:28:29 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli:
> The era of hand-rolled HIWORD_UPDATE macros is over, at least for those
> drivers that use constant masks.
>
> phy-rockchip-samsung-dcphy is actually an exemplary example, where the
> similarities to FIELD_PREP were spotted and the driver local macro has
> the same semantics as the new FIELD_PREP_WM16 hw_bitfield.h macro.
>
> Still, get rid of FIELD_PREP_HIWORD now that a shared implementation
> exists, replacing the two instances of it with FIELD_PREP_WM16. This
> gives us slightly better error checking; the value is now checked to fit
> in 16 bits.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>