From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@alien8.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org,
"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] cpufreq: prevent 'policy->cpus' become offline in __gov_queue_work()
Date: Wed, 05 Jun 2013 14:37:50 +0200 [thread overview]
Message-ID: <1862476.P5VBB45STK@vostro.rjw.lan> (raw)
In-Reply-To: <51AEFDC4.8070801@linux.vnet.ibm.com>
On Wednesday, June 05, 2013 04:58:44 PM Michael Wang wrote:
> Hi, Viresh
>
> On 06/05/2013 04:53 PM, Viresh Kumar wrote:
> [snip]
> >> It was caused by the policy->cpus changed during the process of
> >> __gov_queue_work(), in other word, cpu offline happened.
> >>
> >> This patch will use get/put_online_cpus() to prevent the offline
> >> happen inside __gov_queue_work(), after applied the patch, the
> >> warning is gone as Jiri tested:
> >>
> >> Link: https://lkml.org/lkml/2013/6/5/88
> >>
> >> CC: "Rafael J. Wysocki" <rjw@sisk.pl>
> >> CC: Viresh Kumar <viresh.kumar@linaro.org>
> >> Reported-by: Borislav Petkov <bp@alien8.de>
> >> Reported-by: Jiri Kosina <jkosina@suse.cz>
> >> Tested-by: Jiri Kosina <jkosina@suse.cz>
> >> Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
> >> ---
> >> drivers/cpufreq/cpufreq_governor.c | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Thanks for your ack :)
Queued up for 3.10.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-06-05 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 8:49 [PATCH] cpufreq: prevent 'policy->cpus' become offline in __gov_queue_work() Michael Wang
2013-06-05 8:53 ` Viresh Kumar
2013-06-05 8:58 ` Michael Wang
2013-06-05 12:37 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1862476.P5VBB45STK@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=bp@alien8.de \
--cc=cpufreq@vger.kernel.org \
--cc=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox