From: Thomas Renninger <trenn@suse.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: sriram@marirs.net.in, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpupower Makefile change
Date: Fri, 30 Jan 2015 01:27:23 +0100 [thread overview]
Message-ID: <1889623.OtveQTWjnB@linux-oxht.site> (raw)
In-Reply-To: <2471771.a0lNGTTV6e@vostro.rjw.lan>
On Friday, January 30, 2015 01:13:09 AM Rafael J. Wysocki wrote:
> On Monday, December 22, 2014 10:17:37 PM sriram@marirs.net.in wrote:
> > The cpupower tool, when compiled against libcpupower.so fail's to run as
> > the linker file path's are missing during compilation. So added changes
> > in the Makefile to run cpupower tool, which helps us run the tool
> > without doing a 'make install'.
> >
> >
> > Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>
>
> That requires an ACK from Thomas for me to apply it.
Makes sense.
Acked-by: Thomas Renninger <trenn@suse.de>
Thanks,
Thomas
>
> > ---
> >
> > tools/power/cpupower/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/power/cpupower/Makefile
> > b/tools/power/cpupower/Makefile
> > index 2e2ba2e..3ed7c04 100644
> > --- a/tools/power/cpupower/Makefile
> > +++ b/tools/power/cpupower/Makefile
> > @@ -209,7 +209,7 @@ $(OUTPUT)%.o: %.c
> >
> > $(OUTPUT)cpupower: $(UTIL_OBJS) $(OUTPUT)libcpupower.so.$(LIB_MAJ)
> >
> > $(ECHO) " CC " $@
> >
> > - $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower -lrt
> > -lpci -L$(OUTPUT) -o $@
> > + $(QUIET) $(CC) $(CFLAGS) $(LDFLAGS) $(UTIL_OBJS) -lcpupower
> > -Wl,-rpath=./ -lrt -lpci -L$(OUTPUT) -o $@
> >
> > $(QUIET) $(STRIPCMD) $@
> >
> > $(OUTPUT)po/$(PACKAGE).pot: $(UTIL_SRC)
next prev parent reply other threads:[~2015-01-30 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 16:47 [PATCH] cpupower Makefile change sriram
2015-01-30 0:13 ` Rafael J. Wysocki
2015-01-30 0:27 ` Thomas Renninger [this message]
2015-01-30 23:08 ` Rafael J. Wysocki
2015-01-31 15:55 ` sriram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1889623.OtveQTWjnB@linux-oxht.site \
--to=trenn@suse.de \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sriram@marirs.net.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox