From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: Gregory Greenman <gregory.greenman@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Kalle Valo <kvalo@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Subject: [PATCH v1 0/3] iwlwifi: mvm: Thermal management fixes
Date: Wed, 07 Feb 2024 20:08:18 +0100 [thread overview]
Message-ID: <1892445.tdWV9SEqCh@kreacher> (raw)
Hi Everyone,
There are a few thermal management shortcomings in the iwlwifi driver that are
addressed by this series.
First off, the fw_trips_index[] array field in struct iwl_mvm_thermal_device
is only populated and never read, and the code populating it has problems,
so patch [1/3] removes it.
Second, iwl_mvm_thermal_zone_register() populates the trip table after passing
it to thermal_zone_device_register_with_trips() which is too late, because it
can get used before it is populated. It also may as well use THERMAL_TEMP_INVALID
as the "invalid temperature" value. Both these issues are addressed by patch [2/3].
Finally, iwl_mvm_send_temp_report_ths_cmd() accesses the trip tables used during
thermal zone registration directly in order to obtain the current trip point
temperature values, which is not guaranteed to work in the future, because the
core will store the trips information in its own copy of the trip table - see
this patch series:
https://lore.kernel.org/linux-pm/2728491.mvXUDI8C0e@kreacher/
If possible, I'd like to route the $subject series through the thermal tree,
it is requisite for the above one.
Thanks!
next reply other threads:[~2024-02-07 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 19:08 Rafael J. Wysocki [this message]
2024-02-07 19:09 ` [PATCH v1 1/3] iwlwifi: mvm: Drop unused fw_trips_index[] from iwl_mvm_thermal_device Rafael J. Wysocki
2024-02-07 19:10 ` [PATCH v1 2/3] iwlwifi: mvm: Populate trip table before registering thermal zone Rafael J. Wysocki
2024-02-07 19:12 ` [PATCH v1 3/3] iwlwifi: mvm: Use for_each_thermal_trip() for walking trip points Rafael J. Wysocki
2024-02-08 6:13 ` [PATCH v1 0/3] iwlwifi: mvm: Thermal management fixes Kalle Valo
2024-02-08 9:28 ` Johannes Berg
2024-02-08 13:26 ` Korenblit, Miriam Rachel
2024-02-08 13:50 ` Rafael J. Wysocki
2024-02-08 13:24 ` Korenblit, Miriam Rachel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1892445.tdWV9SEqCh@kreacher \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).