From: "MyungJoo Ham" <myungjoo.ham@samsung.com>
To: "Axel Lin" <axel.lin@ingics.com>
Cc: "Kyungmin Park" <kyungmin.park@samsung.com>,
"Lin Huang" <hl@rock-chips.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH] PM / devfreq: rk3399_dmc: Remove explictly regulator_put call in .remove
Date: Mon, 19 Sep 2016 07:44:54 +0000 [thread overview]
Message-ID: <1951060944.1420539.1474271094626.JavaMail.weblogic@ep1ml103c> (raw)
In-Reply-To: CGME20160918024124epcas1p26e45dd69c71bdcded5b336c87f1b246b@epcas1p2.samsung.com
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
> Current code uses devm_regulator_get() in .probe so a regulator_put() will
> be automatically called when unload the module. Remove the explictly
> regulator_put() call and then we can also remove rk3399_dmcfreq_remove().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/devfreq/rk3399_dmc.c | 10 ----------
> 1 file changed, 10 deletions(-)
Thank you.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Being tested at: https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-4.9-rc
next parent reply other threads:[~2016-09-19 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160918024124epcas1p26e45dd69c71bdcded5b336c87f1b246b@epcas1p2.samsung.com>
2016-09-19 7:44 ` MyungJoo Ham [this message]
2016-09-19 11:08 ` [PATCH] PM / devfreq: rk3399_dmc: Remove explictly regulator_put call in .remove Rafael J. Wysocki
[not found] <CGME20160918024126epcas1p16b581f05e978e0e2014bb20a47e82aec@epcas1p1.samsung.com>
2016-09-18 2:41 ` Axel Lin
2016-09-19 0:16 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1951060944.1420539.1474271094626.JavaMail.weblogic@ep1ml103c \
--to=myungjoo.ham@samsung.com \
--cc=axel.lin@ingics.com \
--cc=cw00.choi@samsung.com \
--cc=hl@rock-chips.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).