linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@sisk.pl
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com,
	l.majewski@samsung.com, Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 05/10] cpufreq: Pass policy to cpufreq_add_policy_cpu()
Date: Sat,  3 Aug 2013 17:19:23 +0530	[thread overview]
Message-ID: <19511592474bddb0737664c79632b3c1341c9956.1375530162.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1375530162.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1375530162.git.viresh.kumar@linaro.org>

Caller of cpufreq_add_policy_cpu() already has pointer to policy structure and
so there is no need to find it again in cpufreq_add_policy_cpu(). Lets pass it
directly.

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/cpufreq.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 47773a9..496e31c 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -889,21 +889,17 @@ static void cpufreq_init_policy(struct cpufreq_policy *policy)
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
-static int cpufreq_add_policy_cpu(unsigned int cpu, unsigned int sibling,
-				  struct device *dev, bool frozen)
+static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy,
+				  unsigned int cpu, struct device *dev,
+				  bool frozen)
 {
-	struct cpufreq_policy *policy;
 	int ret = 0, has_target = !!cpufreq_driver->target;
 	unsigned long flags;
 
-	policy = cpufreq_cpu_get(sibling);
-	if (WARN_ON_ONCE(!policy))
-		return -ENODATA;
-
 	if (has_target)
 		__cpufreq_governor(policy, CPUFREQ_GOV_STOP);
 
-	lock_policy_rwsem_write(sibling);
+	lock_policy_rwsem_write(policy->cpu);
 
 	write_lock_irqsave(&cpufreq_driver_lock, flags);
 
@@ -912,7 +908,7 @@ static int cpufreq_add_policy_cpu(unsigned int cpu, unsigned int sibling,
 	per_cpu(cpufreq_cpu_data, cpu) = policy;
 	write_unlock_irqrestore(&cpufreq_driver_lock, flags);
 
-	unlock_policy_rwsem_write(sibling);
+	unlock_policy_rwsem_write(policy->cpu);
 
 	if (has_target) {
 		__cpufreq_governor(policy, CPUFREQ_GOV_START);
@@ -923,7 +919,6 @@ static int cpufreq_add_policy_cpu(unsigned int cpu, unsigned int sibling,
 	if (!frozen)
 		ret = sysfs_create_link(&dev->kobj, &policy->kobj, "cpufreq");
 
-	cpufreq_cpu_put(policy);
 	return ret;
 }
 #endif
@@ -1006,8 +1001,7 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif,
 		struct cpufreq_policy *cp = per_cpu(cpufreq_cpu_data, sibling);
 		if (cp && cpumask_test_cpu(cpu, cp->related_cpus)) {
 			read_unlock_irqrestore(&cpufreq_driver_lock, flags);
-			return cpufreq_add_policy_cpu(cpu, sibling, dev,
-						      frozen);
+			return cpufreq_add_policy_cpu(cp, cpu, dev, frozen);
 		}
 	}
 	read_unlock_irqrestore(&cpufreq_driver_lock, flags);
-- 
1.7.12.rc2.18.g61b472e

  parent reply	other threads:[~2013-08-03 11:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03 11:49 [PATCH 00/10] CPUFreq: Fixes & Cleanups for 3.12 Viresh Kumar
2013-08-03 11:49 ` [PATCH 01/10] cpufreq: Cleanup header files included in core Viresh Kumar
2013-08-03 17:15   ` Viresh Kumar
2013-08-03 21:42     ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 02/10] cpufreq: Re-arrange declarations in cpufreq.h Viresh Kumar
2013-08-03 17:13   ` Viresh Kumar
2013-08-03 21:43     ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 03/10] cpufreq: Give consistent names for struct cpufreq_policy * Viresh Kumar
2013-08-06 13:38   ` Viresh Kumar
2013-08-06 14:02     ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 04/10] cpufreq: Use sizeof(*ptr) form for finding size of a struct Viresh Kumar
2013-08-03 11:49 ` Viresh Kumar [this message]
2013-08-03 11:49 ` [PATCH 06/10] cpufreq: Store cpufreq policies in a list Viresh Kumar
2013-08-03 11:49 ` [PATCH 07/10] cpufreq: Use cpufreq_policy_list for iterating over policies Viresh Kumar
2013-08-03 11:49 ` [PATCH 08/10] cpufreq: Fix broken usage of governor->owner's refcount Viresh Kumar
2013-08-03 12:08   ` Rafael J. Wysocki
2013-08-03 13:27     ` Viresh Kumar
2013-08-03 22:06       ` Rafael J. Wysocki
2013-08-03 11:49 ` [PATCH 09/10] cpufreq: Don't use cpufreq_driver->owner's refcount to protect critical sections Viresh Kumar
2013-08-03 11:49 ` [PATCH 10/10] cpufreq: Remove struct cpufreq_driver's owner field Viresh Kumar
2013-08-03 12:07 ` [PATCH 00/10] CPUFreq: Fixes & Cleanups for 3.12 Rafael J. Wysocki
2013-08-03 13:28   ` Viresh Kumar
2013-08-03 22:02     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19511592474bddb0737664c79632b3c1341c9956.1375530162.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=l.majewski@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).