From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Artem Savkov <artem.savkov@gmail.com>
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: 64bit divide in intel_pstate_calc_busy()
Date: Mon, 11 Feb 2013 20:42:41 +0100 [thread overview]
Message-ID: <1987087.S730EjTqbJ@vostro.rjw.lan> (raw)
In-Reply-To: <1360610648-6952-1-git-send-email-artem.savkov@gmail.com>
On Monday, February 11, 2013 11:24:08 PM Artem Savkov wrote:
> intel_pstate.c won't compile on i686 because of a linking error:
> drivers/cpufreq/intel_pstate.c:459: undefined reference to `__udivdi3'
>
> Signed-off-by: Artem Savkov <artem.savkov@gmail.com>
I've just applied an equivalent patch from Dirk.
Thanks,
Rafael
> ---
> drivers/cpufreq/intel_pstate.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 86ad482..dc43208 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -456,7 +456,9 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu,
> core_pct = div64_u64(sample->aperf * 100, sample->mperf);
> sample->freq = cpu->pstate.turbo_pstate * core_pct * 1000;
>
> - sample->core_pct_busy = sample->pstate_pct_busy * core_pct / 100;
> + sample->core_pct_busy = div64_u64(
> + sample->pstate_pct_busy * core_pct,
> + 100);
> }
>
> static inline void intel_pstate_sample(struct cpudata *cpu)
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-02-11 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 19:24 [PATCH] cpufreq: 64bit divide in intel_pstate_calc_busy() Artem Savkov
2013-02-11 19:42 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1987087.S730EjTqbJ@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=artem.savkov@gmail.com \
--cc=dirk.brandewie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox