From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [REGRESSION 4.17] Spurious wakeup / reboot with power button Date: Thu, 05 Jul 2018 12:41:03 +0200 Message-ID: <1999215.6UrMtQZ5Bj@aspire.rjw.lan> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: "Rafael J. Wysocki" , Thomas =?ISO-8859-1?Q?H=E4nig?= , Linux PM , Linux Kernel Mailing List List-Id: linux-pm@vger.kernel.org On Thursday, July 5, 2018 11:50:11 AM CEST Takashi Iwai wrote: > On Thu, 05 Jul 2018 11:34:59 +0200, > Rafael J. Wysocki wrote: > > > > Hi, > > > > On Thu, Jul 5, 2018 at 9:05 AM, Takashi Iwai wrote: > > > Hi, > > > > > > we've got a regression report since 4.17 about the behavior of > > > power-off with the power button. When a machine is powered off with > > > the power button on desktop, it reboots after a few seconds instead of > > > power down. > > > > > > The manual power down via "systemctl poweroff" works fine, so it's > > > possibly some spurious wakeup by the power button action, and some > > > ACPI-related change is suspected. > > > The regression still remains in 4.18-rc3. > > > > There are only a few ACPI commits directly related to power management > > between 4.16 and 4.17 and none of them looks particularly suspicious. > > OK, interesting. > > > It looks like the power button state may not be cleared sufficiently > > after it's been pressed which is now visible for some reason. > > Hmm, where can such a state remain? Since it happens after the > machine turned off, some (ACPI) wakeup bits? Basically, yes. It looks like a GPE may remain active which then triggers wakeup after shutdown. On a hunch, I'm wondering if reverting commit 18996f2db918 ACPICA: Events: Stop unconditionally clearing ACPI IRQs during suspend/resume (may not revert clearly, though) makes any difference. Thanks, Rafael