From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>
Cc: kernel@collabora.com, "Chen-Yu Tsai" <wenst@chromium.org>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
"Alexandre Mergnat" <amergnat@baylibre.com>,
"Amit Kucheria" <amitk@kernel.org>,
"Balsam CHIHI" <bchihi@baylibre.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Yangtao Li" <frank.li@vivo.com>,
"Zhang Rui" <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Make readings valid in filtered mode
Date: Fri, 14 Jul 2023 11:23:59 +0200 [thread overview]
Message-ID: <1ab4a9fb-caa4-f2c9-fbf4-d001e768dbe1@collabora.com> (raw)
In-Reply-To: <20230713154743.611870-1-nfraprado@collabora.com>
Il 13/07/23 17:42, Nícolas F. R. A. Prado ha scritto:
> Currently, when a controller is configured to use filtered mode, thermal
> readings are valid only about 30% of the time.
>
> Upon testing, it was noticed that lowering any of the interval settings
> resulted in an improved rate of valid data. The same was observed when
> decreasing the number of samples for each sensor (which also results in
> quicker measurements).
>
> Retrying the read with a timeout longer than the time it takes to
> resample (about 344us with these settings and 4 sensors) also improves
> the rate.
>
> Lower all timing settings to the minimum, configure the filtering to
> single sample, and poll the measurement register for at least one period
> to improve the data validity on filtered mode. With these changes in
> place, out of 100000 reads, a single one failed, ie 99.999% of the data
> was valid.
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
Good to go!
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-07-14 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 15:42 [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Make readings valid in filtered mode Nícolas F. R. A. Prado
2023-07-14 9:23 ` AngeloGioacchino Del Regno [this message]
2023-08-10 22:51 ` Nícolas F. R. A. Prado
2023-08-11 11:01 ` Alexandre Mergnat
2023-08-16 10:21 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ab4a9fb-caa4-f2c9-fbf4-d001e768dbe1@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=amitk@kernel.org \
--cc=bchihi@baylibre.com \
--cc=bero@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=frank.li@vivo.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).