From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5570730C370 for ; Wed, 5 Nov 2025 11:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762341766; cv=none; b=HznF0XepAXx4uwwnww67Ijavzd2UNSRfwnfAm8hDEFXNlff54CklzO1sNZO7buIOx73KEA9hshuxcCqTjgoygUxhrzgOPIgvWoJlaP6DSF8bouOeAb1PuPieO89U3spNRts9yVngWdAATr6IY7JbXK7ItuqHRgn0InUWJOi2Xr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762341766; c=relaxed/simple; bh=Ii9b2rpzXiRDukDeUtY2WS5XvNAk5U97MkCbAXQdp7s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JxjfYkKHGgZWhzgtpA0pbquSYuQD/H9QDtjn6JPiPYyc5+EAj42x9arVIGFFvZhsDyhx9yz+6O5SkIQTn7hunq0oAAVKVBpozX+ibC+XNNMkovkAn3zedWSRBG/MpfLrvturt5pW4YNdEuxUKn5VzlPBIWDpViifUW2TGSNZFOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ugo+/H9y; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ugo+/H9y" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-378d50e1c77so52645501fa.0 for ; Wed, 05 Nov 2025 03:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762341762; x=1762946562; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Lgjq5frjKtchDAt0hCN8TCDb53mEX1KChcG+cIgj+As=; b=Ugo+/H9y30ONhr7fDfdxbpsqWR3tRjLh+BuyplYG+qinlo2qxVVE4FuU4lqg9t8UmP fVDVTXoFX4dBwApTOCOGf3JNHagxzSd5IcYye46YRifeue4oQvK+rCDY6250s2aOUHg5 fWNdaQqGIKnqGL+6iwoCI4B1KwMjvSghMySRVbLo/w8XC1vtrbeE+e8rvaXdbSppm6Pu jwzcMBE7OMaVCmpZm+PQVU/4EMvbFWk7ZoQe404b7k5sOktFJtHcSqzL3FIgWmRkzwO0 dAicFKMGSMh+zzlQdFh553R+WyaxAPatOLu++DAI9JeRl9GL5PnvoTJduTUCYgVMQAlm q8Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762341762; x=1762946562; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lgjq5frjKtchDAt0hCN8TCDb53mEX1KChcG+cIgj+As=; b=IpC37BjxI+N0aaXhKQXN83fWIeh3LYKWT8S0fZ+5Lvq/uRGvHf8U/NJb9PfFhuFplX RDOfWNn0kTHIqLaJpGUDXHkTS4hEg/IezeCiVu3oVkhl1QuXA1pSTHXuwGYwZoAOYJd/ OVZlZqCM/Ct+oOMNaUkK+7GIdDm64CW/R2O05/q126W/ejzGlZm/S2SEsrnCcK7cKOax 4OSWJdr9bLQZuBw7j1kXb08j6xgP1sojCZXNvBvKIFhZJRf13k99M97VBtWn0fiuTiWo wOJ9AAy+m1MSIzi1jHqmYTkNPgyh/6UueY9+7BSho0fpQJMqT/YD6lSxr1rbl0Vpwatq dSfA== X-Forwarded-Encrypted: i=1; AJvYcCWjK/ofP5iZYKgRMB2T2uUmGBFlFgmcu7w2XhwmNCQLSNkWMtZx1xnk0aWmQvt8IZpj4gXOxoURRg==@vger.kernel.org X-Gm-Message-State: AOJu0Yxon4lkbyKvhSuxKFq8Z8teAbFrfnODKslnTxhZTVHqdBjnDarn xRpXdb1zudVLncOObnyjK49ZZjtEv7IdfrewddcllwtY+phyFoJUjOHi X-Gm-Gg: ASbGnctBl3fdWYxJsDS4iZnRxXgG/X1k0NaI8LSz1/Vy61SdNwqtCh6SZluHXlnPKre CQTxT131ncYotjamO+dXZJzW7O3XtNlbALEDumCosE5Wa514vDcEIV7bC7yBDDjFrDf+euJfXD3 6dhawB/mijivCzqoD/Xj4SddqDaO5txAsaW/OKaBOMW72TdOkNibUhDhSO+oENL5N09vSS/eVUx qH/jdpIluFYbc2nzZ75V9xuwOMd3M6t6drLv9qC7N0WuuT7cdI0mmCB4Z0uYjOM7cigPFDThWrT PylLVwlIoYUVbGF3SGixxEnSQThXhUzvRdLct0Wq3XihRkbqbsb3mICBLieZk8wpmpIVc0jeZ0B iS3R7DkyNih7yvcZdmJRup2UAm1iPuXMJ43gTJkPrcXxnfQt2t6cl+GpzlxKw/Mhex24XrZ22ex YxuUmbmsExjCxNuCz/47iVjfQ78kXvH9jgT+9caSChsDeyjpXhz8FETCGguQ== X-Google-Smtp-Source: AGHT+IHpvSjuUZgOT3CU6iwhd3QH+qr/blJkYgQLVxgzQhufOUjboKrykT4Eu5lvIJTa8VYLu1Svkg== X-Received: by 2002:a05:651c:4006:b0:37a:3b04:1a1b with SMTP id 38308e7fff4ca-37a513e604fmr6509411fa.12.1762341762189; Wed, 05 Nov 2025 03:22:42 -0800 (PST) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37a415c8070sm14290231fa.28.2025.11.05.03.22.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Nov 2025 03:22:41 -0800 (PST) Message-ID: <1aedf1a8-ddff-47fd-8afb-dd60dc42e12b@gmail.com> Date: Wed, 5 Nov 2025 13:22:40 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/16] dt-bindings: regulator: ROHM BD72720 To: "Rob Herring (Arm)" , Matti Vaittinen Cc: Conor Dooley , linux-kernel@vger.kernel.org, Lee Jones , devicetree@vger.kernel.org, Linus Walleij , Sebastian Reichel , Andreas Kemnade , Bartosz Golaszewski , Alexandre Belloni , Stephen Boyd , Pavel Machek , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-leds@vger.kernel.org, Matti Vaittinen , Michael Turquette , linux-rtc@vger.kernel.org, Liam Girdwood , Mark Brown References: <48fe6e2642db4484640b173cd71be1b245929122.1762327887.git.mazziesaccount@gmail.com> <176233320981.143013.4115240062372455834.robh@kernel.org> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <176233320981.143013.4115240062372455834.robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/11/2025 11:00, Rob Herring (Arm) wrote: > > On Wed, 05 Nov 2025 09:35:59 +0200, Matti Vaittinen wrote: >> From: Matti Vaittinen >> >> The ROHM BD72720 is a new PMIC with 10 BUCk and 11 LDO regulators. >> >> The BD72720 is designed to support using the BUCK10 as a supply for >> the LDOs 1 to 4. When the BUCK10 is used for this, it can be set to a >> LDON_HEAD mode. In this mode, the BUCK10 voltage can't be controlled by >> software, but the voltage is adjusted by PMIC to match the LDO1 .. LDO4 >> voltages with a given offset. Offset can be 50mV .. 300mV and is >> changeable at 50mV steps. >> >> Add 'ldon-head-microvolt' property to denote a board which is designed >> to utilize the LDON_HEAD mode. >> >> All other properties are already existing. >> >> Add dt-binding doc for ROHM BD72720 regulators to make it usable. >> >> Signed-off-by: Matti Vaittinen >> >> --- >> Revision history: >> v2 => v3: >> - drop unnecessary descriptions >> - use microvolts for the 'ldon-head' dt-property >> >> RFCv1 => v2: >> - No changes >> --- >> .../regulator/rohm,bd72720-regulator.yaml | 149 ++++++++++++++++++ >> 1 file changed, 149 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml: patternProperties:^buck[1-10]$:properties:rohm,ldon-head-microvolt: '$ref' should not be valid under {'const': '$ref'} > hint: Standard unit suffix properties don't need a type $ref > from schema $id: http://devicetree.org/meta-schemas/core.yaml Nice! I'm not sure if anyone has said it but these bots are helpful :) I forgot the type to ldon-head when switching from -millivolt to -microvolt. I'll address this for the next version. > doc reference errors (make refcheckdocs): Thanks for including the make -command to the mail! I didn't even know about 'refcheckdocs' target. > Warning: Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml > Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml: Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml Hmm. I suppose this is because the MFD binding is added only later in the series(?) I suppose we can't help it because the MFD binding references the regulator binding as well. So, this is kind of a chicken and egg problem? Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~