linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre Bailon <abailon@baylibre.com>,
	rafael@kernel.org, daniel.lezcano@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: rui.zhang@intel.com, lukasz.luba@arm.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/6] ARM64: mt8195: Use thermal aggregation for big and little cpu
Date: Mon, 27 May 2024 08:56:52 +0200	[thread overview]
Message-ID: <1b691b03-1d2c-48ee-9907-dc043ea1ed5d@linaro.org> (raw)
In-Reply-To: <20240524143150.610949-7-abailon@baylibre.com>

On 24/05/2024 16:31, Alexandre Bailon wrote:
> This uses the thermal aggregation for the mt8195 to get the maximal
> temperature of big and little cpu clusters.
> 
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 212 +++--------------------
>  1 file changed, 27 insertions(+), 185 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 5d8b68f86ce4..8aa2bf142622 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -3600,50 +3600,31 @@ dp_tx: dp-tx@1c600000 {
>  	};
>  
>  	thermal_zones: thermal-zones {
> -		cpu0-thermal {
> +		cpu-little {

How is it related to the commit?

Does not look tested. You just introduced warnings.

Best regards,
Krzysztof


  reply	other threads:[~2024-05-27  6:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 14:31 [PATCH v3 0/6] thermal: Add support of multiple sensors Alexandre Bailon
2024-05-24 14:31 ` [PATCH v3 1/6] dt-bindings: thermal: Restore the thermal-sensors property Alexandre Bailon
2024-05-24 14:31 ` [PATCH v3 2/6] thermal: Add support of multi sensors to thermal_core Alexandre Bailon
2024-05-27  7:00   ` Krzysztof Kozlowski
2024-05-27  7:02     ` Krzysztof Kozlowski
2024-05-29  8:23     ` Alexandre Bailon
2024-05-24 14:31 ` [PATCH v3 3/6] thermal: Add support of multi sensors to thermal_of Alexandre Bailon
2024-05-24 14:31 ` [PATCH v3 4/6] dt-bindings: thermal: Add a property to select the aggregation type Alexandre Bailon
2024-05-27  6:55   ` Krzysztof Kozlowski
2024-05-29  8:06     ` Alexandre Bailon
2024-05-28 17:00   ` Rob Herring
2024-05-24 14:31 ` [PATCH v3 5/6] thermal: of: Parse aggregation property to select the aggegration type Alexandre Bailon
2024-05-24 14:31 ` [PATCH v3 6/6] ARM64: mt8195: Use thermal aggregation for big and little cpu Alexandre Bailon
2024-05-27  6:56   ` Krzysztof Kozlowski [this message]
2024-05-29  8:19     ` Alexandre Bailon
2024-05-29 12:39       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b691b03-1d2c-48ee-9907-dc043ea1ed5d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=abailon@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).