From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C45AC43217 for ; Sat, 19 Nov 2022 12:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233680AbiKSM7L (ORCPT ); Sat, 19 Nov 2022 07:59:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233106AbiKSM7G (ORCPT ); Sat, 19 Nov 2022 07:59:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BFC09CF62 for ; Sat, 19 Nov 2022 04:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668862685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=att0kd8Ei9hnRQ7//eGic4U9uIgK4F47gd3Pen4Nml4=; b=E5rvBsAyHWMvXBrqCrPMkM60GNZbN/akx1MbwRvi6SLg3pIu2KqqgyuSuElUBGDOBrIcVR Ciitg4paBV1hnOpfa5IyX7dGiLfGRYvnSGqM+VWSSk+3+pBc2j3csI2e0UhRCsim++Us3O OWM74UMVWuWgwNlUvpXMAEqkSQ0nyco= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-304-h2RfAOPUMCuioD2fvSQMMQ-1; Sat, 19 Nov 2022 07:58:03 -0500 X-MC-Unique: h2RfAOPUMCuioD2fvSQMMQ-1 Received: by mail-ed1-f72.google.com with SMTP id z15-20020a05640240cf00b00461b253c220so4118311edb.3 for ; Sat, 19 Nov 2022 04:58:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=att0kd8Ei9hnRQ7//eGic4U9uIgK4F47gd3Pen4Nml4=; b=dEhAcFJdRNjHlkxa19nLnEjSzIrJOZQXRgXEfuCllxNyRJgLTkZsKYUcHnWz+3RzUb WO8ReiRS9cUJ8xJqsO1blsRX6yp2H0Z4SQxJsdM9wUImaMcsOXzwZmvnlvbxHPuevhCf xfE2tqvjw9/fovK20OSDQK+SwX6R6zhoGVAOR7hOSm8f/2ZksmPiQEZn8raG0djsZLvj wgyQ0ds0cubAcpbGsBuEwlXqNeSUxTpMP+xPzCdcUaA2kXBh1K5KTC8EhyjqErnzoqB5 Irwi644CwLQqQjKJHafHELaFht3rP3v9K9zogjeASrTcq/ERPqbU1R/1/ROeQD+Fc53g 66rw== X-Gm-Message-State: ANoB5pmEfzHNFYTLziLHq3MdwR6rj+KkBywRPoM8eJEvkRM6I76BiZwM Q1yqRHcoVwnd5oxAD/sBaQ/oJStLtbmQvcxTyPb9DVuAOSDCDpK+mMFXPndwrRssq9O4aqQr0NN yBN3KARMB8mwdxgIUqnM= X-Received: by 2002:aa7:d1cc:0:b0:468:f964:372e with SMTP id g12-20020aa7d1cc000000b00468f964372emr7805886edp.326.1668862682564; Sat, 19 Nov 2022 04:58:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Ra+xt2V3m680hjIDqNisNFkDT6A55mp2gEd2PzLtjvyisa18iNaOjHiKcRdh6G30b8IU+oQ== X-Received: by 2002:aa7:d1cc:0:b0:468:f964:372e with SMTP id g12-20020aa7d1cc000000b00468f964372emr7805862edp.326.1668862682337; Sat, 19 Nov 2022 04:58:02 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id jt12-20020a170906ca0c00b007aec44edcfcsm2841094ejb.75.2022.11.19.04.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 04:58:01 -0800 (PST) Message-ID: <1c8cee3a-41e1-d02a-d7cf-549d91ac0143@redhat.com> Date: Sat, 19 Nov 2022 13:58:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 529/606] power: supply: max17042_battery: Convert to i2c's .probe_new() Content-Language: en-US, nl To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Sebastian Reichel Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-530-uwe@kleine-koenig.org> From: Hans de Goede In-Reply-To: <20221118224540.619276-530-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On 11/18/22 23:44, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/power/supply/max17042_battery.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c > index ab031bbfbe78..89cabe8ed3b0 100644 > --- a/drivers/power/supply/max17042_battery.c > +++ b/drivers/power/supply/max17042_battery.c > @@ -1031,9 +1031,9 @@ static const struct power_supply_desc max17042_no_current_sense_psy_desc = { > .num_properties = ARRAY_SIZE(max17042_battery_props) - 2, > }; > > -static int max17042_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int max17042_probe(struct i2c_client *client) > { > + const struct i2c_device_id *id = i2c_client_get_device_id(client); > struct i2c_adapter *adapter = client->adapter; > const struct power_supply_desc *max17042_desc = &max17042_psy_desc; > struct power_supply_config psy_cfg = {}; > @@ -1220,7 +1220,7 @@ static struct i2c_driver max17042_i2c_driver = { > .of_match_table = of_match_ptr(max17042_dt_match), > .pm = &max17042_pm_ops, > }, > - .probe = max17042_probe, > + .probe_new = max17042_probe, > .id_table = max17042_id, > }; > module_i2c_driver(max17042_i2c_driver);