Linux Power Management development
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
	Casey Connolly <casey.connolly@linaro.org>,
	Jakob Hauser <jahau@rocketmail.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Tobias Schrammm <t.schramm@manjaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: power: supply: summit,smb347: Add missing power-supply ref
Date: Wed, 4 Jun 2025 10:39:04 +0200	[thread overview]
Message-ID: <1ca76e4a-fe95-41b2-9f72-6c1a6219cbff@ixit.cz> (raw)
In-Reply-To: <20250604-dt-bindings-psy-monitored-battery-v1-5-7f755ff75218@linaro.org>

Thank you,

Reviewed-by: David Heidelberg <david@ixit.cz>


On 04/06/2025 10:18, Krzysztof Kozlowski wrote:
> Reference the common power supply schema to bring the definition of
> monitored-battery property.  Drop also the obvious description because
> it is duplicating what is in power-supply.yaml.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   .../devicetree/bindings/power/supply/summit,smb347-charger.yaml      | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> index 2d552becbfe6cb08c72f2a5584bdddc67443a2e4..65ed92bb05f30f91e24978d3261c7f29e4233e2b 100644
> --- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> @@ -23,9 +23,7 @@ properties:
>     interrupts:
>       maxItems: 1
>   
> -  monitored-battery:
> -    description: phandle to the battery node
> -    $ref: /schemas/types.yaml#/definitions/phandle
> +  monitored-battery: true
>   
>     summit,enable-usb-charging:
>       type: boolean
> @@ -94,6 +92,7 @@ properties:
>       unevaluatedProperties: false
>   
>   allOf:
> +  - $ref: power-supply.yaml#
>     - if:
>         properties:
>           compatible:
> 

  reply	other threads:[~2025-06-04  8:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04  8:18 [PATCH 0/6] dt-bindings: power: supply: Few cleanups around monitored-battery Krzysztof Kozlowski
2025-06-04  8:18 ` [PATCH 1/6] dt-bindings: power: supply: bq2515x: Add missing power-supply ref Krzysztof Kozlowski
2025-06-04  8:18 ` [PATCH 2/6] dt-bindings: power: supply: bq256xx: " Krzysztof Kozlowski
2025-06-04  8:18 ` [PATCH 3/6] dt-bindings: power: supply: qcom,pmi8998: " Krzysztof Kozlowski
2025-06-11  9:01   ` Casey Connolly
2025-06-04  8:18 ` [PATCH 4/6] dt-bindings: power: supply: richtek,rt5033: " Krzysztof Kozlowski
2025-06-04  8:18 ` [PATCH 5/6] dt-bindings: power: supply: summit,smb347: " Krzysztof Kozlowski
2025-06-04  8:39   ` David Heidelberg [this message]
2025-06-04  8:18 ` [PATCH 6/6] dt-bindings: power: supply: Drop redundant monitored-battery ref Krzysztof Kozlowski
2025-06-10 12:28   ` Linus Walleij
2025-06-22  0:10 ` [PATCH 0/6] dt-bindings: power: supply: Few cleanups around monitored-battery Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ca76e4a-fe95-41b2-9f72-6c1a6219cbff@ixit.cz \
    --to=david@ixit.cz \
    --cc=afd@ti.com \
    --cc=casey.connolly@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=jahau@rocketmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=t.schramm@manjaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox