From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5843F2BEC2E for ; Fri, 12 Sep 2025 09:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757669265; cv=none; b=Q1PxWiJufg2ttE4chRaEeRRKvh0tVE5BMsurwrGa1S+32uCN7OoRPb7IBsxdp8T0I46pBEkaHszeRChDUdHkZZACT/jRC4M/gP2PhkyKVPBuW19WGkBTCvIpHOxwkiPLEWxT5DURfrh79o0PhWCmPUz5rcW9ObpxvFjggA2O4tM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757669265; c=relaxed/simple; bh=37s8rtihJZjYcqXMR+EBo1VCyOiF0M83FLmCNi4lZoo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t/24NFlsep0nXLtQNdPMASBPzYWF+/NO7RYxyVP0hiGe4GOxnNU7qexqtNr83o55NIp8VqS/cgiTtKjQ7CbQs4dLslg+bNqiwYNwLkPqh/ERtaxyERRoWOZ5SXdOUrU/WJcXM70XBjYPb+0rB38vNp7mTwBxpROYKH/3ybhJMM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iZn5Rdv0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iZn5Rdv0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45dd0d53e04so3050885e9.1 for ; Fri, 12 Sep 2025 02:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757669261; x=1758274061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=sJZVDaBONrsctBuO8ClmLLuGVSMSeIuOQj38qMjOEC4=; b=iZn5Rdv00r1dKn6QwHXIeW9s7n2haQe/HLb7WrVcE3mI8jXLTETTM/zOFWGApEYsPV IN162GzFi70aMvyxeBVpe6mlQFkUBN9zLvvcW5UdpiCGT4RGapwa3Cafvvr3YCskLuNQ X55xvPQuNaqbOGqXyEKkPVBBUYyii01p3bWaBq9VKYjq6s/9Co3NRZryChpzoroxX8ss 3bRhkR3i97Qn/o069pmIbAb09vY9nzJf7JCMgFUx1+C57+gfcKPEUFgvHAX8M2cqBUcW pRmiKrd9qLvCqTCKfxHluZ2mER00uewTBjUrLhOUGnEfPMU9TSfz5OM3QexfzCy0ylzS MJbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757669261; x=1758274061; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sJZVDaBONrsctBuO8ClmLLuGVSMSeIuOQj38qMjOEC4=; b=DKq/h1waT7Rt2OlmTQn4V6N1C8wSYQYjscRsEEh96zd9F+W9lzehxl33hcJNdCmWym neW/NnR+Cm9MTFGAzED4ovESd8H8/DjmcEkwXMW+9k3amwdMzRLHRpHWJKqWz3fuE2dD Qyhk2REB6jWhdDLR9upiNkvyYttil86lW9LQTf7IWOdmIqMioHaerXeuwqzbwHezZHLe i7ZtAWJOiss/o5aBOosXDqF3NqRIQGRK634DwVjFLjn0ORjsXzT1KFMWWu+TLKF9R1ym 6p2WYPYPG9Z8d1AmIPFkCGuS0SowMqkCVorAjEaCCHvZfgLYHHhatSrYjM9lfe3VQrJW +IdA== X-Forwarded-Encrypted: i=1; AJvYcCXBqjEjISxKfqvGw1Msk/ow9X4mmEvjurJBdedWxC6/OceS3NY43WdXkYN+AAcAOgeixMUuYQJN9A==@vger.kernel.org X-Gm-Message-State: AOJu0YzKY19eacS0uHhXxNOO34nxJ+3zsr46OVcAub2Pss5Iwl9f3dc1 QBGslb2Ec4hRXhT7/Zy8keyKwLjRZjIlAM/TmEHDANpnwrDUqbjdeQ3FEjGvS0aJobU= X-Gm-Gg: ASbGnctnKTLT0Jz98WaF0Wev0S+Ssvc94OEiAY3DpmjH6D6z2nK0rbviMY/ZwCnGsJY Je49LK2oU+Bu1IrDKo4wWbPi/7bt4R8t15LD8v+Q3lbE7JyZFYhy1lPci5vhIXSZhFmhr9WIQln 97sUWOR+GB209+q8FzmMVr5nWnrbK1H927HDluI42ATYvZVhLYsH++qdHufqK+jvbsMUfoIHz74 qQNpL5I/eRV6ITZolOooEUGhVHmJ0xhBjU+6oKYoO5dzqKxE4eLkdWajbKDy3TtWZNi56ZyBlA4 uOGbtnt+yr5O3a3doLQqaF+Qj4xg+Mwpny3TskFTVYWR4+dUoljrgi7dsArqer0o2QOSz5Upqwv cazPWiEuZOYPosRaSQbImfxymAlcvqRN76FXRexQcJ3FEziQGXfJv4w== X-Google-Smtp-Source: AGHT+IFeZIHH+GDuy21c93peZqwyLtGWxcpHg3tJXLEty5kBn/g+Fv9K4spsV8IDT41h2TXjrk+9LQ== X-Received: by 2002:a05:600c:8707:b0:45c:b627:a4e3 with SMTP id 5b1f17b1804b1-45f21e65defmr9674305e9.1.1757669261507; Fri, 12 Sep 2025 02:27:41 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e0156d206sm60274825e9.5.2025.09.12.02.27.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 02:27:40 -0700 (PDT) Message-ID: <1cd6a0f9-2955-4189-8d1e-85fa8ad8dddd@linaro.org> Date: Fri, 12 Sep 2025 11:27:38 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/10] dt-bindings: clock: Add required "interconnect-cells" property To: Konrad Dybcio , Luo Jie Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Varadarajan Narayanan , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Anusha Rao , Manikanta Mylavarapu , Devi Priya , Philipp Zabel , Richard Cochran , Konrad Dybcio , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_pavir@quicinc.com, quic_suruchia@quicinc.com References: <20250909-qcom_ipq5424_nsscc-v5-0-332c49a8512b@quicinc.com> <20250909-qcom_ipq5424_nsscc-v5-2-332c49a8512b@quicinc.com> <20250912-nocturnal-horse-of-acumen-5b2cbd@kuoka> <2951b362-c3c1-4608-8534-4d25b089f927@oss.qualcomm.com> <52714c33-5bd7-4ca5-bf1d-c89318c77746@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/09/2025 11:21, Konrad Dybcio wrote: > On 9/12/25 11:17 AM, Krzysztof Kozlowski wrote: >> On 12/09/2025 11:13, Konrad Dybcio wrote: >>> On 9/12/25 11:13 AM, Konrad Dybcio wrote: >>>> On 9/12/25 9:04 AM, Krzysztof Kozlowski wrote: >>>>> On Tue, Sep 09, 2025 at 09:39:11PM +0800, Luo Jie wrote: >>>>>> The Networking Subsystem (NSS) clock controller acts as both a clock >>>>>> provider and an interconnect provider. The #interconnect-cells property >>>>>> is mandatory in the Device Tree Source (DTS) to ensure that client >>>>>> drivers, such as the PPE driver, can correctly acquire ICC clocks from >>>>>> the NSS ICC provider. >>>>>> >>>>>> Although this property is already present in the NSS CC node of the DTS >>>>>> for CMN PLL for IPQ9574 SoC which is currently supported, it was previously >>>>>> omitted from the list of required properties in the bindings documentation. >>>>>> Adding this as a required property is not expected to break the ABI for >>>>>> currently supported SoC. >>>>>> >>>>>> Marking #interconnect-cells as required to comply with Device Tree (DT) >>>>>> binding requirements for interconnect providers. >>>>> >>>>> DT bindings do not require interconnect-cells, so that's not a correct >>>>> reason. Drop them from required properties. >>>> >>>> "Mark #interconnect-cells as required to allow consuming the provided >>>> interconnect endpoints"? >>> >>> "which are in turn necessary for the SoC to function" >> >> If this never worked and code was buggy, never booted, was sent >> incomplete and in junk state, then sure. Say like that. :) >> >> But I have a feeling code was working okayish... > > If Linux is unaware of resources, it can't turn them off/on, so it was > only working courtesy of the previous boot stages messing with them. Which is fine and present in all other cases/drivers/devices. Entire Linux in many places relies on bootloader and that is not a "work by coincidence". Another thing is if you keep backwards compatibility in the driver but want to enforce DTS to care about these resources, but that is not explained here, I think. Best regards, Krzysztof