Re: [PATCH 3/4] dt-bindings: power: reset: convert nvmem-reboot-mode bindings to YAML

Krzysztof Kozlowski
2023-04-16T15:20:14Z

On 13/04/2023 15:17, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Convert the DT binding document for nvmem-reboot-mode from .txt to YAML.

Thank you for your patch. There is something to discuss/improve.

> diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> new file mode 100644
> index 000000000000..64a7d224c7dd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/nvmem-reboot-mode.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic NVMEM reboot mode driver

Drop "driver".
> +
> +maintainers:
> + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + This driver gets the reboot mode magic value from the reboot-mode driver
> + and stores it in the NVMEM cell named "reboot-mode". The bootloader can
> + then read it and take different action according to the value.
> +
> +properties:
> + compatible:
> + const: nvmem-reboot-mode
> +
> + nvmem-cells:
> + description: |

Do not need '|' unless you need to preserve formatting.

> + A phandle pointing to the nvmem-cells node where the vendor-specific
> + magic value representing the reboot mode is stored.
> + maxItems: 1
> +
> + nvmem-cell-names:
> + items:
> + - const: reboot-mode
> +
> +patternProperties:
> + "^mode-.+":
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Vendor-specific mode value written to the mode register
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - nvmem-cells
> + - nvmem-cell-names

put required: before additionalProperties

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof