Re: [PATCH v4] intel_idle: introduce 'no_native' module parameter

Artem Bityutskiy
2025-02-20T12:50:50Z

On Tue, 2025-02-18 at 20:57 +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 13, 2025 at 5:07 PM David Arcari <darcari@redhat.com> wrote:
> >
> > Since commit 18734958e9bf ("intel_idle: Use ACPI _CST for processor models
> > without C-state tables") the intel_idle driver has had the ability to use
> > the ACPI _CST to populate C-states when the processor model is not
> > recognized. However, even when the processor model is recognized (native
> > mode) there are cases where it is useful to make the driver ignore the per
> > cpu idle states in lieu of ACPI C-states (such as specific application
> > performance). Add the 'no_native' module parameter to provide this
> > functionality.
> >
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: David Arcari <darcari@redhat.com>
> > Cc: Artem Bityutskiy <dedekind1@gmail.com>
> > Cc: Prarit Bhargava <prarit@redhat.com>
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: David Arcari <darcari@redhat.com>
> > ---
> > v4: fix !CONFIG_ACPI_PROCESSOR_CSTATE compilation issue
>
> Artem, have all of your comments been addressed in this version?

Hi, I was away for few days. Yes, this patch looks good to me. Works, and
useful. Granted your comment is also addressed:

Reviewed-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>