From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 08/10] PM / OPP: Rename dev_pm_opp_get_suspend_opp() and return OPP rate
Date: Tue, 6 Dec 2016 14:46:00 +0530 [thread overview]
Message-ID: <1da9ba0dd518f51fa73ca33e06ba868a267fb5d6.1481015522.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1481015522.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1481015522.git.viresh.kumar@linaro.org>
There is only one user of dev_pm_opp_get_suspend_opp() and that uses it
to get the OPP rate for the suspend_opp.
Rename dev_pm_opp_get_suspend_opp() as dev_pm_opp_get_suspend_opp_freq()
and return the rate directly from it.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp/core.c | 27 +++++++++++++--------------
drivers/cpufreq/cpufreq-dt.c | 7 +------
include/linux/pm_opp.h | 6 +++---
3 files changed, 17 insertions(+), 23 deletions(-)
diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c
index 6bcbb64a5582..6fd098618683 100644
--- a/drivers/base/power/opp/core.c
+++ b/drivers/base/power/opp/core.c
@@ -328,32 +328,31 @@ unsigned long dev_pm_opp_get_max_transition_latency(struct device *dev)
EXPORT_SYMBOL_GPL(dev_pm_opp_get_max_transition_latency);
/**
- * dev_pm_opp_get_suspend_opp() - Get suspend opp
+ * dev_pm_opp_get_suspend_opp_freq() - Get frequency of suspend opp
* @dev: device for which we do this operation
*
- * Return: This function returns pointer to the suspend opp if it is
- * defined and available, otherwise it returns NULL.
- *
- * Locking: This function must be called under rcu_read_lock(). opp is a rcu
- * protected pointer. The reason for the same is that the opp pointer which is
- * returned will remain valid for use with opp_get_{voltage, freq} only while
- * under the locked area. The pointer returned must be used prior to unlocking
- * with rcu_read_unlock() to maintain the integrity of the pointer.
+ * Return: This function returns the frequency of the OPP marked as suspend_opp
+ * if one is available, else returns 0;
*/
-struct dev_pm_opp *dev_pm_opp_get_suspend_opp(struct device *dev)
+unsigned long dev_pm_opp_get_suspend_opp_freq(struct device *dev)
{
struct opp_table *opp_table;
+ unsigned long freq = 0;
- opp_rcu_lockdep_assert();
+ rcu_read_lock();
opp_table = _find_opp_table(dev);
if (IS_ERR(opp_table) || !opp_table->suspend_opp ||
!opp_table->suspend_opp->available)
- return NULL;
+ goto unlock;
- return opp_table->suspend_opp;
+ freq = dev_pm_opp_get_freq(opp_table->suspend_opp) / 1000;
+
+unlock:
+ rcu_read_unlock();
+ return freq;
}
-EXPORT_SYMBOL_GPL(dev_pm_opp_get_suspend_opp);
+EXPORT_SYMBOL_GPL(dev_pm_opp_get_suspend_opp_freq);
/**
* dev_pm_opp_get_opp_count() - Get number of opps available in the opp table
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index 269013311e79..d0a53119d8a2 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -148,7 +148,6 @@ static int cpufreq_init(struct cpufreq_policy *policy)
struct private_data *priv;
struct device *cpu_dev;
struct clk *cpu_clk;
- struct dev_pm_opp *suspend_opp;
unsigned int transition_latency;
bool fallback = false;
const char *name;
@@ -252,11 +251,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
policy->driver_data = priv;
policy->clk = cpu_clk;
- rcu_read_lock();
- suspend_opp = dev_pm_opp_get_suspend_opp(cpu_dev);
- if (suspend_opp)
- policy->suspend_freq = dev_pm_opp_get_freq(suspend_opp) / 1000;
- rcu_read_unlock();
+ policy->suspend_freq = dev_pm_opp_get_suspend_opp_freq(cpu_dev);
ret = cpufreq_table_validate_and_show(policy, freq_table);
if (ret) {
diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
index 0edd88f93904..7483ff291a8e 100644
--- a/include/linux/pm_opp.h
+++ b/include/linux/pm_opp.h
@@ -88,7 +88,7 @@ int dev_pm_opp_get_opp_count(struct device *dev);
unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev);
unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev);
unsigned long dev_pm_opp_get_max_transition_latency(struct device *dev);
-struct dev_pm_opp *dev_pm_opp_get_suspend_opp(struct device *dev);
+unsigned long dev_pm_opp_get_suspend_opp_freq(struct device *dev);
struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
unsigned long freq,
@@ -159,9 +159,9 @@ static inline unsigned long dev_pm_opp_get_max_transition_latency(struct device
return 0;
}
-static inline struct dev_pm_opp *dev_pm_opp_get_suspend_opp(struct device *dev)
+static inline unsigned long dev_pm_opp_get_suspend_opp_freq(struct device *dev)
{
- return NULL;
+ return 0;
}
static inline struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
--
2.7.1.410.g6faf27b
next prev parent reply other threads:[~2016-12-06 9:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 9:15 [PATCH 00/10] PM / OPP: Fixes and cleanups Viresh Kumar
2016-12-06 9:15 ` [PATCH 01/10] PM / OPP: Fix memory leak while adding duplicate OPPs Viresh Kumar
2016-12-07 1:09 ` Stephen Boyd
2016-12-07 3:23 ` Viresh Kumar
2016-12-06 9:15 ` [PATCH 02/10] PM / OPP: Remove useless TODO Viresh Kumar
2016-12-07 1:10 ` Stephen Boyd
2016-12-07 3:24 ` Viresh Kumar
2016-12-06 9:15 ` [PATCH 03/10] PM / OPP: Rename _allocate_opp() to _opp_allocate() Viresh Kumar
2016-12-07 1:10 ` Stephen Boyd
2016-12-06 9:15 ` [PATCH 04/10] PM / OPP: Error out on failing to add static OPPs for v1 bindings Viresh Kumar
2016-12-07 1:17 ` Stephen Boyd
2016-12-07 3:25 ` Viresh Kumar
2016-12-07 21:13 ` Stephen Boyd
2016-12-08 3:30 ` Viresh Kumar
2016-12-08 6:39 ` Shawn Guo
2016-12-08 6:45 ` Viresh Kumar
2016-12-08 14:27 ` Shawn Guo
2016-12-08 14:47 ` Viresh Kumar
2016-12-06 9:15 ` [PATCH 05/10] PM / OPP: Add light weight _opp_free() routine Viresh Kumar
2016-12-07 1:12 ` Stephen Boyd
2016-12-06 9:15 ` [PATCH 06/10] PM / OPP: Rename and split _dev_pm_opp_remove_table() Viresh Kumar
2016-12-07 1:19 ` Stephen Boyd
2016-12-06 9:15 ` [PATCH 07/10] PM / OPP: Don't allocate OPP table from _opp_allocate() Viresh Kumar
2016-12-07 1:02 ` Stephen Boyd
2016-12-07 4:17 ` Viresh Kumar
2016-12-07 22:05 ` Stephen Boyd
2016-12-08 3:45 ` Viresh Kumar
2016-12-22 0:43 ` Stephen Boyd
2016-12-06 9:16 ` Viresh Kumar [this message]
2016-12-07 1:21 ` [PATCH 08/10] PM / OPP: Rename dev_pm_opp_get_suspend_opp() and return OPP rate Stephen Boyd
2016-12-07 4:20 ` Viresh Kumar
2016-12-06 9:16 ` [PATCH 09/10] PM / OPP: Don't expose srcu_head to register notifiers Viresh Kumar
2016-12-07 1:22 ` Stephen Boyd
2016-12-06 9:16 ` [PATCH 10/10] PM / OPP: Split out part of _add_opp_table() and _remove_opp_table() Viresh Kumar
2016-12-07 1:24 ` Stephen Boyd
2016-12-07 4:25 ` Viresh Kumar
[not found] ` <CGME20161206091647epcas4p1823f471816de0ef953123a8fbdac4b1f@epcas4p1.samsung.com>
2016-12-07 0:29 ` [PATCH 09/10] PM / OPP: Don't expose srcu_head to register notifiers MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da9ba0dd518f51fa73ca33e06ba868a267fb5d6.1481015522.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).