From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
rui.zhang@intel.com, amitk@kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 3/4] thermal/drivers/intel_powerclamp: Use powercap idle-inject framework
Date: Tue, 17 Jan 2023 15:55:23 +0100 [thread overview]
Message-ID: <1e3d8fba-b706-6b4e-2a19-c150ee85d152@linaro.org> (raw)
In-Reply-To: <CAJZ5v0h5uu5UWyzTJV=RPdoyEB41-dBheOy4C05tVXpKinZtvQ@mail.gmail.com>
On 17/01/2023 15:49, Rafael J. Wysocki wrote:
> On Tue, Jan 17, 2023 at 12:16 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 17/01/2023 03:07, Srinivas Pandruvada wrote:
>>
>> [ ... ]
>>
>>> diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
>>> index f0c845679250..6c2a95f41c81 100644
>>> --- a/drivers/thermal/intel/Kconfig
>>> +++ b/drivers/thermal/intel/Kconfig
>>> @@ -3,6 +3,8 @@ config INTEL_POWERCLAMP
>>> tristate "Intel PowerClamp idle injection driver"
>>> depends on X86
>>> depends on CPU_SUP_INTEL
>>> + select POWERCAP
>>> + select IDLE_INJECT
>>
>> Just a question, not a comment. As IDLE_INJECT depends on POWERCAP, is
>> it necessary to select POWERCAP also here ?
>
> Yes, it is.
>
> If IDLE_INJECT alone is selected, POWERCAP may not be and there will
> be a broken dependency.
Ok, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-01-17 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 2:07 [PATCH v3 0/4] Per CPU idle injection Srinivas Pandruvada
2023-01-17 2:07 ` [PATCH v3 1/4] powercap: idle_inject: Export symbols Srinivas Pandruvada
2023-01-17 9:34 ` Daniel Lezcano
2023-01-17 2:07 ` [PATCH v3 2/4] powercap: idle_inject: Add update callback Srinivas Pandruvada
2023-01-17 11:13 ` Daniel Lezcano
2023-01-17 15:08 ` srinivas pandruvada
2023-01-17 15:09 ` Rafael J. Wysocki
2023-01-19 18:01 ` srinivas pandruvada
2023-01-17 2:07 ` [PATCH v3 3/4] thermal/drivers/intel_powerclamp: Use powercap idle-inject framework Srinivas Pandruvada
2023-01-17 11:16 ` Daniel Lezcano
2023-01-17 14:49 ` Rafael J. Wysocki
2023-01-17 14:55 ` Daniel Lezcano [this message]
2023-01-17 2:07 ` [PATCH v3 4/4] thermal/drivers/intel_cpu_idle_cooling: Introduce Intel cpu idle cooling driver Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3d8fba-b706-6b4e-2a19-c150ee85d152@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox