From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C52DC7EE23 for ; Thu, 1 Jun 2023 10:03:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233218AbjFAKDa (ORCPT ); Thu, 1 Jun 2023 06:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233233AbjFAKCl (ORCPT ); Thu, 1 Jun 2023 06:02:41 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 037D61728 for ; Thu, 1 Jun 2023 03:01:24 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4f3baf04f0cso700044e87.1 for ; Thu, 01 Jun 2023 03:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685613680; x=1688205680; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7ioEn//NQFT+oZEC++gXomowkVto8H1YOn/EZNzbn6s=; b=ReOwnsrpA4kmhUrZv8TuJtTLcy3Yuql4TSfPEYMJxkQisD6BKRqh7WzsJpaqxTCNO/ JdXJNQ2aarCzwxh7akL1CkHY7dZP+HkCss2bmsemBjaCY53OOXo6sMlEwd2L17qeguAc Mwtbgj13VjQIVVHGxWK6muY/RRwfXNdjxdlG4ECEQf9gto1Qu2vvsYIRJrll9CTHAQu8 Xr4uxneoYv2VmEy3Tc6J2f3745BlkBPf2IC5XF5w8tGNbXFBTAlNybeJoAm24UkFFAS6 NYGRAH4v3TMRN9w0ZV/wE+aaClznitFw5prgLwWy0c4Q8bN2UEJZlvAVNOh5g9TOdkzD MVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685613680; x=1688205680; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7ioEn//NQFT+oZEC++gXomowkVto8H1YOn/EZNzbn6s=; b=Hd8HUKktuWZIgwoZS15Tx8ytPy5+uxxV88abrSO6WZYK3v4OoDOzt+sFVcwAzrz80l bhv2zQJOhE5oV+f0ztuQtKrCyWYNT+nOMv4wThFqEgGO+H+ru675RgYjVn6GWk8TWV4B 8m8JFzs8iBu9OP+2tN87eOFo4n+H5CN9qHclhasoPsmF4a+grA9Rns5aGiQLCLmu6QBT lv+njzzuV32bMABZRNjHEoXtEZFA/jIxAZixzwvzY3Zt3zxWra8ZF+Zy+HLbjgm/ZI8M cdrfkAxhkEyDofxoS7yAJsxDMY1tHUokeJVK2oVnXpBja5wL53mroFQHFv5W6t9EEzjN jmww== X-Gm-Message-State: AC+VfDy+HChmCJ4orbuygO5ISp/JHMjTpo08NQnF9SRRSTi1s3oy/pWq mc3wy1xYv/1DfWN95XjVpV+m+w== X-Google-Smtp-Source: ACHHUZ45A2zkOvmoul2/6LZWTZ/lgfoERO9Kxkw51MKhHfF4Vqw08RldTLbMkVp2uuThiEwd7qfS7g== X-Received: by 2002:ac2:4c13:0:b0:4f3:8258:5894 with SMTP id t19-20020ac24c13000000b004f382585894mr1128367lfq.27.1685613680554; Thu, 01 Jun 2023 03:01:20 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id m7-20020a056512014700b004edce1d338csm1027007lfo.89.2023.06.01.03.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 03:01:20 -0700 (PDT) Message-ID: <1f43abe6-faf3-3d87-a49f-12f2a62eafd9@linaro.org> Date: Thu, 1 Jun 2023 12:01:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 01/20] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Leo Yan , Evan Green Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org References: <20230526-topic-smd_icc-v1-0-1bf8e6663c4e@linaro.org> <20230526-topic-smd_icc-v1-1-1bf8e6663c4e@linaro.org> <2679410b-b40d-97b5-b7c2-46f32395b796@linaro.org> From: Konrad Dybcio In-Reply-To: <2679410b-b40d-97b5-b7c2-46f32395b796@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 1.06.2023 11:20, Dmitry Baryshkov wrote: > On 30/05/2023 13:20, Konrad Dybcio wrote: >> Add a preprocessor define to indicate the number of RPM contexts/states. >> While at it, use tabs instead of spaces for the existing entries. >> >> Signed-off-by: Konrad Dybcio >> --- >>   include/linux/soc/qcom/smd-rpm.h | 5 +++-- >>   1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h >> index 2990f425fdef..99499e4b080e 100644 >> --- a/include/linux/soc/qcom/smd-rpm.h >> +++ b/include/linux/soc/qcom/smd-rpm.h >> @@ -4,8 +4,9 @@ >>     struct qcom_smd_rpm; >>   -#define QCOM_SMD_RPM_ACTIVE_STATE        0 >> -#define QCOM_SMD_RPM_SLEEP_STATE         1 >> +#define QCOM_SMD_RPM_ACTIVE_STATE    0 >> +#define QCOM_SMD_RPM_SLEEP_STATE    1 > > This is what we usually try to abstain from: ident changes + functional changes. I'd say, leave spaces as is and just add the new entry. I think I might wanna turn this into an enum.. Also, I'd like to rename it but that's a story for another day, as it'd require even more messy merging.. Konrad > >> +#define QCOM_SMD_RPM_STATE_NUM        2 >>     /* >>    * Constants used for addressing resources in the RPM. >> >