From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v1] thermal: intel: int340x: Fix unitialized variable error
Date: Tue, 24 Jan 2023 17:40:28 +0100 [thread overview]
Message-ID: <1f70f2a2-3bc2-586f-67da-76b1c8379ff6@linaro.org> (raw)
In-Reply-To: <2685606.mvXUDI8C0e@kreacher>
On 24/01/2023 17:38, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If PATC evaluation fails in int340x_thermal_zone_add(), trip_cnt will
> not be initialized when allocating the trips array later.
>
> Address this by initializing trip_cnt to 0.
>
> While at it, move the status variable definition lower for better
> code readability.
>
> Fixes: d58c653e9e26 ("thermal: intel: int340x: Use generic trip points")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2023-01-24 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 16:38 [PATCH v1] thermal: intel: int340x: Fix unitialized variable error Rafael J. Wysocki
2023-01-24 16:40 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f70f2a2-3bc2-586f-67da-76b1c8379ff6@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox