From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D97F3DFC89 for ; Thu, 5 Mar 2026 17:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772730431; cv=none; b=C9U7QsLW8Npwi5tpKL1iK7QWG8iEzvO1gVq3InsMvMUhlhUASXtiKi3xM46Otz5woKBosoZ7mtLcw3WbTemP8SA7SxZTkK6OADytcYm7jRhR7RcCCMNkhlr4hYPI8d0dk+G9z3Tr2KnIjzX7BQ11uNt2ihyA/6/TDbnwomhWzkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772730431; c=relaxed/simple; bh=pgP0q4kVsHFcrHbvYtzYON7ox6KLWsq/00U7ee8fSJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZhOZObzr3THUNsHfwmyOTAZV/8xNg/eQ3qLW2cV5wVYcShcVygR+awYGKxg/0uXBbOV6gkoPfWujdY9KKs8idHgn924rd8ewKIGfLU+c3o3aQKa+hZl/SfOKCHVLG4mkWwWgnYAYXZ94W6TezpK4rFIcUohHUMJ9TikJPsX3rYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a4bEybrX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Typ50wuy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a4bEybrX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Typ50wuy" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625AG4ni936997 for ; Thu, 5 Mar 2026 17:07:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P9amGm3yXPjWRedkzMCt3rIna/u2e58sR65tEMjLkZI=; b=a4bEybrXskoGZv0G azDDjfpL2IOffTbrcBuFG67SPotuiTOys4t+8fwGZFuXAThGyia+MdFPamiAnnkT StMJYJp2iyF90+1NwpdnGs78OqSctI1r60JSwVcog+/aLGd44RS4ysAda3s0lxqQ klZ/sO1w1Uec0bLVnGgh6xrBTPw+tZmyopB25LlZvQYB2mG8SUoS8GLMK2bU/NhQ rkuJpbieG8FfRmrqYDDqq6vEH8BYNzpwVSjJnvkgwkebOqqiUpqe8dejBshev8NJ zAVC02J3kIE3bAHpvFLVsT3d+xAg1u+TQF6Dx4lQFS98Wr+QdvpIbr1K+gr5ovi1 Z9rqYg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq04u2yfm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 17:07:09 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35449510446so7769921a91.0 for ; Thu, 05 Mar 2026 09:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772730428; x=1773335228; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P9amGm3yXPjWRedkzMCt3rIna/u2e58sR65tEMjLkZI=; b=Typ50wuySwlOR5roqdDNG8zr4zyB9KbOQ2f6J0KTSizJM/A2Q/ROXAJ7E3O40STX6z Uh9x8ego73/dseTIQTtNIK5nAmHfYtcEnCKQGoR88KwmmFXrQjmZCjmxToGCW2IE8AjE 05LPO8y7WEuEffHzoDzgSmNLnmwW4PWlF4ahpu/D+5q0owd09V7rnKr3Io9HP/YSBOcK DXSiDJ0yyoerM1gATDTBOpShW0nFTsxySPjDX69tkEtfnGLvHsfJ/3bqIHcSNMV0hwx9 DKspq49g62iIXIXYC5yubTDWMal2E/KG1l2gxse7hNAocGJmTQzRcbnucf22d2yxjWLK SpBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772730428; x=1773335228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P9amGm3yXPjWRedkzMCt3rIna/u2e58sR65tEMjLkZI=; b=PZFZ72IYOf6KDqnqs84JLjoUdPwWO+fysv9nRgxvTBqTo7cD5Gc3KYC6bzbsVOjtuw D85UqdHwFEckhnWb+aX5nT0XqJUBKl2WJP6m5Xo4vuMSl0tFe9Fn0FNzgW0pwomluvrY gVqUpSQmDuq0ljYDtGjwI4iAoPBL6nxLjKPoCpBj3EMcXIeLYp8XSUvrJXM2hc5Ql5zZ 1Xi1xnCgcz8DwK6WcOm/gok7YZNn8EyDS4H/i/Te3sW+KuuNS7jEcjvUqB86kao4OM+p Q7Y3MIdZ+Byb03RN9bv+TZGpqEDuELngy2M5/PvY8TO2AbmLvbPwJFbjFgzt2sQ8CXOd jAiQ== X-Forwarded-Encrypted: i=1; AJvYcCV4DJXKypqozc8deXEPLIMophxR7huMhfomFn+PoTwYzuCs5cikHkvCLhHkEgMOdFBB/Lr7JqE3kQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxOH4MERcORYgNXSaKAo9igwWS0Jl3UKhYFnQr/D1a9ahug8uFx wiJNB4BxdJ7+ao0JXM0xhxmYn+KSKytDMQjH1wol9dkLGKxaiy0OgcNx8XkWOD5zbws/bZxgosY pWQnvpOLISzXypT6HRnw9RAuVfEHwW4sVxM8Eaa9DbiFjnaB/va9dbSc7qUTtkg== X-Gm-Gg: ATEYQzz8VwlsFVA7m+yTN2cXU1ON/ZRTpM/rAM43kzE6X4pwCpPLQUZG2mX2SgG3QRV lIT41kdrMpXp+NikRR3ELxpw7cbBzdgNdo5qpwpPA3WGhQOX/TpEgM30cSjg71u/YqgZ1elxMSh J9ScYFlXPmRN3ddONbnXfboBJKAVA7aTcnhd/VZxjgJFv23TX5aiz4/CXgyGLNPNQ/OPKMoB0vD m9jmbsULhMZmjkzcBoOZ0Nw6fcnB64WcgLNscuBQFFCptPfwP02yEmqtKQrptjD7AzVFP79jgOM fGHbZVXHCHLIAC3VLHR2ziimQbLQZDP5P4wi2wU6KSb0SGfomaySzCZW3SF1vDNhv8i6vHKG2jH cLvEDylzlK1n2mMgP68S8u6iWuSdLvITKjIZVtGHbg494571zOHati+Y= X-Received: by 2002:a17:90b:3e4c:b0:359:2d1c:9206 with SMTP id 98e67ed59e1d1-359bb45b0b8mr219554a91.33.1772730427631; Thu, 05 Mar 2026 09:07:07 -0800 (PST) X-Received: by 2002:a17:90b:3e4c:b0:359:2d1c:9206 with SMTP id 98e67ed59e1d1-359bb45b0b8mr219498a91.33.1772730426982; Thu, 05 Mar 2026 09:07:06 -0800 (PST) Received: from [192.168.29.31] ([49.43.226.5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359aa2c02casm1708265a91.8.2026.03.05.09.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 09:07:06 -0800 (PST) Message-ID: <1f75b250-c3b5-45da-bc82-aeadf44dfea4@oss.qualcomm.com> Date: Thu, 5 Mar 2026 22:36:26 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v20 06/10] power: reset: Add psci-reboot-mode driver To: Bartosz Golaszewski Cc: Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla , Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Sebastian Reichel , Rob Herring , Souvik Chakravarty , Krzysztof Kozlowski , Andy Yan , Matthias Brugger , Mark Rutland , Conor Dooley , Konrad Dybcio , John Stultz , Moritz Fischer , Sudeep Holla References: <20260304-arm-psci-system_reset2-vendor-reboots-v20-0-cf7d346b8372@oss.qualcomm.com> <20260304-arm-psci-system_reset2-vendor-reboots-v20-6-cf7d346b8372@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: RGQj5LWvkNNq9vuKYo23JOA2TwRkUa45 X-Authority-Analysis: v=2.4 cv=eqTSD4pX c=1 sm=1 tr=0 ts=69a9b83d cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=mvMbtr4cKWCpcPtdaitTtQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=xSGJYzCLABdN7Qz2ucIA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: RGQj5LWvkNNq9vuKYo23JOA2TwRkUa45 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDEzOSBTYWx0ZWRfXxAJNWz6dNL1C BgcoJPW0St/GCjqCT/mOG+BdOvci/eEPW6BZMhbp9Z7g5cvL4ngpgKY9r86+vr4tdFGHwZDNUAG bMMke6nHnqoajLAbzwt88BC4hFAn+jlFyIyOyuifoPzWeInEXa3GqD3aBevt/9+jW4paXyQpvYe zXIUvkQy73Jr98j8rp8Be2EQoZU7j16h1k81vW6jyuOLsQWEpNUOlzi1YhKs+6RHZD8mnWaxDZU kVs4Unnt1uoA6VtzUaZ2I11bR0IyfOIYmAGLzLGdRSN000vGejk75NxD7UY/QT/cIcFoVw17t0m tiR+png7EwYFZl4uFEdzkcXCMbAkbKv/vpAiuLXD92b4TiVcOaemwdHY5Y5OBxUwn6SLhwiYu65 1BnTCE/qzdAL/Odzl44lrHufUMGm0HOQvB3TUqSys7gJQ8C8Oib1HGkpevUyihrmSeiyZpA9sJb 9l/GuEy2ZZvKAezhh+g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_04,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050139 On 05-03-2026 15:32, Bartosz Golaszewski wrote: > On Wed, 4 Mar 2026 19:03:06 +0100, Shivendra Pratap > said: >> PSCI supports different types of resets like COLD reset, ARCH WARM >> reset, vendor-specific resets. Currently there is no common driver that >> handles all supported psci resets at one place. Additionally, there is [snip..] >> +static int psci_reboot_mode_register_device(struct faux_device *fdev) >> +{ >> + struct reboot_mode_driver *reboot; >> + int ret; >> + >> + reboot = devm_kzalloc(&fdev->dev, sizeof(*reboot), GFP_KERNEL); > > Have you verified that the faux device is actually getting bound? This is not > probe(), you don't supply any faux operations when calling faux_device_create(). yes. It was verified. faux device got created like below and the end-to-end use-cases are also working fine. few logs from device: -- # find / -name psci-reboot-mode /sys/devices/faux/psci-reboot-mode /sys/bus/faux/devices/psci-reboot-mode /sys/bus/faux/drivers/faux_driver/psci-reboot-mode # ls ./sys/devices/faux/psci-reboot-mode driver subsystem uevent -- > > You should pass the address of this function in faux_device_ops instead of > calling it directly. In last patch, we were using a probe function. As faux_device_create, calls the probe from its internal operations, "of_node" can only be assigned from inside of faux device probe. As our primary requirement is to assign reboot-mode of_node to the faux device, thought to make it this way. (As we did not want to assign it inside the faux device probe). thanks, Shivendra