From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06046C74A4B for ; Sat, 11 Mar 2023 17:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbjCKRyh (ORCPT ); Sat, 11 Mar 2023 12:54:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjCKRyg (ORCPT ); Sat, 11 Mar 2023 12:54:36 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF45959D6; Sat, 11 Mar 2023 09:54:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7E43FB80066; Sat, 11 Mar 2023 17:54:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08725C433D2; Sat, 11 Mar 2023 17:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678557272; bh=z2cWlGV1bcM9jzPNtM9QNL0pjVBEAIJSORCobXsuCfU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t93fSk76dMiXMENVkaQV4v/sl1rw0NGyqPBmFtGMMo6YHGkqTRxwKXSvANmMN+Stp E+5OZ1ct8iqicuM4/5oWyw+6QEWR/Rju8GRLFQWVHYQjXqdpSUbANCV/7qVqP6oUCm HCht02ze2o2l60LRqXm9vomuxlOG68waE7A3uihF4J10ccu6kNBmWOmy8UmnxOZZtr GGHAA+IFP5Y7e3pYBLpZDJlqwH4GmCFG6gm9lvauTRplJFd+rWGe29e2nfLGWutRoC 2iwAb0zu+86q7tXq3PpgSYcF90AP07EF14vsvhandIsI7ox0HIR4FLWk8i60JfoMe7 0AUBThzKpxKIg== Received: by mercury (Postfix, from userid 1000) id 579B1106095F; Sat, 11 Mar 2023 18:54:29 +0100 (CET) Date: Sat, 11 Mar 2023 18:54:29 +0100 From: Sebastian Reichel To: Linus Walleij Cc: Matti Vaittinen , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCHv1 01/11] dt-bindings: power: supply: adc-battery: add binding Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230309225041.477440-1-sre@kernel.org> <20230309225041.477440-2-sre@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r33a6f5pdav5vdbc" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --r33a6f5pdav5vdbc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Linus, On Fri, Mar 10, 2023 at 09:14:39AM +0100, Linus Walleij wrote: > Hi Sebastian, >=20 > thanks for your patches! >=20 > On Thu, Mar 9, 2023 at 11:50=E2=80=AFPM Sebastian Reichel wrote: >=20 > > Add binding for a battery that is only monitored via ADC > > channels and simple status GPIOs. > > > > Signed-off-by: Sebastian Reichel >=20 > This does look very useful. :) > > +title: ADC battery > > + > > +maintainers: > > + - Sebastian Reichel > > + > > +description: | > > + Basic Battery, which only reports (in circuit) voltage and optionally > > + current via an ADC channel. >=20 > I would over-specify: "voltage over the terminals" and > "current out of the battery" so this cannot be misunderstood. >=20 > + this text: >=20 > It can also optionally indicate that the battery is full by pulling a GPIO > line. Ack. >=20 > > + charged-gpios: > > + description: > > + GPIO which signals that the battery is fully charged. >=20 > It doesn't say how, I guess either this is an analog circuit (!) or > a charger IC? If it doesn't matter, no big deal, but if something is > implicit here, then spell it out please. In my case the GPIO is provided by a charger chip, that is not software controllable (just reports charge-done & charger-connected via GPIOs). I've seen something similar in a customer device some years ago. I will add a sentence: The GPIO is often provided by charger ICs, that are not software controllable. > > + fuel-gauge { >=20 > This techno-lingo/slang term is a bit unfortunate, but if there are > precedents then stick with it. >=20 > The correct term could be something like battery-capacity-meter > I suppose. Right now in DT we have - specific node name (e.g. chip names) that should be changed :) - smart-battery - battery - fuel-gauge I think fuel-gauge is the most sensible of that list, considering hardware vendors usually call their chips battery fuel gauge. -- Sebastian --r33a6f5pdav5vdbc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQMwFEACgkQ2O7X88g7 +pr7kBAAmyDSM90DC1hkH6XIxMuE1dgd9pZvygODosBhLZzRDgo+eCiRmmpUHky4 5SpD/AK2vuptrYpv+p3yGrUorWUUE0kvNU0PMS5ID0CO7+6HOwALVhov1Mvk4oO5 a+WKYx4jV0t7FMvHe8GJ9r+ni4ywgCvRrAfVYIzHU67G+3pfURIc5SMh7UreQg+x +Iies0ihL86aijszMhfsaX/0+zudlRa+dSwRZ9w72dqgvO0ksUNZl3bp2Z2/W6MR OwbSUQmIBBxVVPs/1re18+F+GgxOkaghomxkLHLTF9shNtB5SRIqLDRi2Mszi6H2 Rmp8sQH4IDtKFC3EtJ1qCqRceTH/6tf+kNXSQ/8fw3pLZsLRy49DGsRshW5qaLm8 qRTZ8GU3XsbFGQgx1+GHSpzdCbTdH9Nbq+QsmETm2dl8HMFFGmMYSMWVUeixRWAx tU2js6NhXJMEtl2MnjMeYUWWzKBLpDUN8AqPeMe/XvfG7RHmLjUHh8nwNqXxrZCk 7ttaRH4e8lJJNGkcbXDWQsMAaGNCBBl22GPwYNdVnE963p4BlpaPf85VzJbGmSR8 QmW2FuPueIv74B5HPzWUlfG2G4NN85NEmeUpXxfmr92iHbVr1DLLHKMjCxkbnecq tPLCWhkdyD//zknvWI0+6nNuGNxx+XEhgJBLQR09jrTQtABciWc= =MH4X -----END PGP SIGNATURE----- --r33a6f5pdav5vdbc-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57434C6FD1C for ; Sun, 12 Mar 2023 17:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjCLRHu (ORCPT ); Sun, 12 Mar 2023 13:07:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCLRHt (ORCPT ); Sun, 12 Mar 2023 13:07:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06F052330B; Sun, 12 Mar 2023 10:07:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 81FE660F64; Sun, 12 Mar 2023 17:07:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAFCFC433D2; Sun, 12 Mar 2023 17:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678640866; bh=D+mLpwz4VKHHeNXrNwruBX6RwwU/I9bGtXKO/ptBcO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aZYDUfULOZNPPa/uIob9DJM3A0HKjbdA37qLGXlsgB2VC0ID6o3TNiIjdAcmLQBtX sgET5c9Sckix6JiuqKkQoBFVYhDUmOlvu7GgUd3f04/5OAUcUvhOOXzP3kFgeON2zU J+nfOqVTtRBYEqbtTQmp1GYE/7drLBKzxqR4p7oKGxLgUt3E0ba10UiZIlKPmunGIB wMinw8AYbeAlY3Vac5hKZON9e0IMZqqOApEa2My3kxDDqhS/IAeG8zmQyvU4EeoRSn AaMgm1m+gTr8bDuBpH3XnMO5itiLKNp2KIDgDwQQPgkBBgcFmo2wQGagbeyaj/1ij0 +fvrGs5ygbjMQ== Received: by mercury (Postfix, from userid 1000) id 014751060FD4; Sun, 12 Mar 2023 18:07:42 +0100 (CET) Date: Sun, 12 Mar 2023 18:07:42 +0100 From: Sebastian Reichel To: Linus Walleij Cc: Matti Vaittinen , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCHv1 02/11] power: supply: core: auto-exposure of simple-battery data Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230309225041.477440-1-sre@kernel.org> <20230309225041.477440-3-sre@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q46upqfjfsur6qqf" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312170742.fUeYZwikMcN8tyVpoGnzl42VW05rz70FCMCnajhHLs0@z> --q46upqfjfsur6qqf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 10, 2023 at 09:20:09AM +0100, Linus Walleij wrote: > On Thu, Mar 9, 2023 at 11:50=E2=80=AFPM Sebastian Reichel wrote: >=20 > > + /* > > + * Set if constant battery information from firmware should be > > + * exposed automatically. No driver specific code is required > > + * in that case. If the driver also handles a property provided > > + * by constant firmware data, the driver's handler is preferred. > > + */ > > + bool expose_battery_info; >=20 > Playing it safe with opt-in I see! But I would probably invert it and > add a hide_battery_info for those that don't wanna expose it. It seems > pretty useful to just expose this in general. I just did not yet spend the time to understand if there are any issues. I guess I can do it now and then remove the opt-in part. > However I have no insight in what happens on laptops etc for this > so I guess you have your reasons, either way: ACPI based systems should be fine, since battery info does not yet support ACPI and thus nothing changes for them. > Reviewed-by: Linus Walleij >=20 > > +extern bool power_supply_battery_info_has_prop(struct power_supply_bat= tery_info *info, > > + enum power_supply_proper= ty psp); > > +extern int power_supply_battery_info_get_prop(struct power_supply_batt= ery_info *info, > > + enum power_supply_propert= y psp, > > + union power_supply_propva= l *val); >=20 > I think the build robots complain because you need to add some stubs > for the not enabled case. I don't think so. They are only used from code needing POWER_SUPPLY being enabled. One reported error is about the array of battery_info properties not being used when POWER_SUPPLY is disabled. I will move that array to a better place. The other error is about power_supply_get_property(), because I accidently removed the EXPORT_SYMBOL_GPL(power_supply_get_property). I did not notice myself, because I compiled a monolithic kernel for the thermal camera for easy deployment. Thanks for the review, much appreciated! -- Sebastian --q46upqfjfsur6qqf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOBtgACgkQ2O7X88g7 +pqBWQ/9FFIeo0ooLJOsidujg3C8gFt9suZlyAeFA1fcubvUY4C7WdXHJDxSy/t9 cfXlwdScebDwapJ2arOY3nJHfHTtwx1Fk3Ubjgt6xPBV6KZQlZXE6O+WsIitlJKt PrtlT+cdcYITxbrYvZsJGWGDIEACn3ewB9w4WUZiBHYBHWswtrP5KLoSyp1mZQLD l6VlUB/1awtKqjoh/+AES/67Zvv9BYbYrLdh/HBW+E/mdw0hKYu3jBCvyxOLpWFR YUuRIdBWmt7I0F0fjarWw5j3Ze/TtS6hieAkXtdIOREqYQABFFMQQc6nZliUOjC3 B2SHJPtJNQ7fNlar5zFbpFFsVWAm7VBcGRDGGoGsMu2pTCnAHjx7p74qS2ny4I4V +GF/oH2VpLnUfraw3yrZ4B4dia50unYBrBYZTc4gVC2CMGjPDzmS29DpWbcbyYHY RMnPb6xB3OmfHB7VfY3NubbxBEwkXX8Omb7pjvJHH0PDc2QhvMEpkJoJa92UWbpn Du2J5dnkwGWWr5aQgjGBuF28L0fj1/AKpXTzONYoTDaavBFKXNNQKpWQicWnCvdy hxG6piP3iA/kNpOGPGQxiNngSPoOnZp4RI/XwPzs/hoGHuv8aDxPSNiDpIg1Q65V ZbuPDI2a+bQfp6ZkiXQz19aWlyvveW6x2YxREbQ5/z6s6e78b88= =kmXQ -----END PGP SIGNATURE----- --q46upqfjfsur6qqf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFCFC74A5B for ; Sun, 12 Mar 2023 22:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbjCLW1j (ORCPT ); Sun, 12 Mar 2023 18:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbjCLW1i (ORCPT ); Sun, 12 Mar 2023 18:27:38 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E35823A84D; Sun, 12 Mar 2023 15:27:36 -0700 (PDT) Received: from mercury (unknown [185.254.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0C1B56602F13; Sun, 12 Mar 2023 22:27:35 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678660055; bh=pfSGgC1MHC1inDZRNev1szq2shFsVqcF8UF6pcGKhUM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AjsgF9lblP2BLTyRiButy2m/pvm7GNUjAFPKYGUVGvyD/T83X40zKRXr2FKqEO6e+ +z9cBGXRiX7oak+40rfB+0pnJ1/RXXa3LUpvetumR6wvYRi/hvpkxYlT6bdS8u9dsR J8ib9RO55B/4330/PtrWzwFqFQBAsy/ksBuMEydCLcBlWgZBWmdj6VdWeurbLWxTUi hkKhcGlOKMzBgr/thE34WT1Oo3+3ohmm/QfAz/G4ODllaAFgX1YV5m83adimHyOMST tJUXhJosmxwb7FPwqUEALS+ZcM1uIg1B+wX8dstLTUyRubBizdVLSqCjMAKK/slT3c O4qnJ27t2/yeg== Received: by mercury (Postfix, from userid 1000) id 556501060FD4; Sun, 12 Mar 2023 23:27:32 +0100 (CET) Date: Sun, 12 Mar 2023 23:27:32 +0100 From: Sebastian Reichel To: Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] power: supply: rt9455_charger: mark OF related data as maybe unused Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230311111532.251604-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="syfqm4melu6qgcjv" Content-Disposition: inline In-Reply-To: <20230311111532.251604-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312222732.4raP72WYZLY3miTdYmltbTDCMnVwH2lXjLvn79658Nw@z> --syfqm4melu6qgcjv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks, I queued all 6 patches to power-supply's for-next queue. -- Sebastian On Sat, Mar 11, 2023 at 12:15:27PM +0100, Krzysztof Kozlowski wrote: > The driver can be compile tested with !CONFIG_OF making certain data > unused: >=20 > drivers/power/supply/rt9455_charger.c:1725:34: error: =E2=80=98rt9455_o= f_match=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D] >=20 > Signed-off-by: Krzysztof Kozlowski > --- > drivers/power/supply/rt9455_charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/power/supply/rt9455_charger.c b/drivers/power/supply= /rt9455_charger.c > index 31fb6526a1fd..0149e00f2bf8 100644 > --- a/drivers/power/supply/rt9455_charger.c > +++ b/drivers/power/supply/rt9455_charger.c > @@ -1722,7 +1722,7 @@ static const struct i2c_device_id rt9455_i2c_id_tab= le[] =3D { > }; > MODULE_DEVICE_TABLE(i2c, rt9455_i2c_id_table); > =20 > -static const struct of_device_id rt9455_of_match[] =3D { > +static const struct of_device_id rt9455_of_match[] __maybe_unused =3D { > { .compatible =3D "richtek,rt9455", }, > { }, > }; > --=20 > 2.34.1 >=20 --syfqm4melu6qgcjv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOUc0ACgkQ2O7X88g7 +ppodRAApys6iqD/+L5Vsetj/LOFNu6sm2+lG+3lWY49uhOmNJ4zZBi1hJynH637 pZFPkyWqLpiJ0XziJCSAgjj0IvkF++6T6PUjGuWU5HIUAKTplqI9ET1D3+WEh8z3 AZYBcAfxSXC6JH9ipfHHevF4a92r5fQ214nUDvfXDTxysirmsV3mmxrGe3N2N9v8 GGq53BkkaaiaDXrWYIIKXa4cYUQ3TXn+baQnTstUHSxKnWRRSgbRTrfaHL1yi2YF D3C/gaQlfYSgAkKQgL5WOKViX7SiolTid65kM2UXaFF1Dv/SGuvIz0qX/SV8Rhfp PMfcXRQdgtBQnJnPEA4owfv/iV5JjdXqcrX6ybNMyS7l9gj4ui9V/SfDnKxqlrN2 ykl5QGZRbnf/Oxt3QYoZPR/uXnKI7uvRTG5FK4C227Swc3/p2k1kh/Xgbo+Qfw7l Iq1ou7e3Ons8GW54zJSC2B/jS6WEfpkbj3f89yPqIZcdL9+l8enRWTR1jKINocUN 3cGIbGNOk67JTzJFhiES7f0LwH3x9LM0U5s9v9gKZ/K+3zyRdcjL/wIIfO6EV9oQ QfgMSFp9vUFoMIb9BKFwgPwKjx3Puz6l+QvHM7psee4VXR2dfobti+wdsC0QQpqq y9k3gCaCldPF56xW1zwN/0lN0wGv6IYLDpL94IF+kBJ/VDR6x/g= =OgAo -----END PGP SIGNATURE----- --syfqm4melu6qgcjv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 597C8C74A4B for ; Sun, 12 Mar 2023 22:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjCLWbY (ORCPT ); Sun, 12 Mar 2023 18:31:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjCLWbW (ORCPT ); Sun, 12 Mar 2023 18:31:22 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ABBB2C645; Sun, 12 Mar 2023 15:31:21 -0700 (PDT) Received: from mercury (unknown [185.254.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8D05B6602F13; Sun, 12 Mar 2023 22:31:19 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678660279; bh=yUmV/Mjx17lxOmMA4cP3sFkL46N/lDYO7FhWwaVfMMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AXk2NpVB+8MSoKloqICjnN6RGhm2lWhvfVFKqW54FxHX6/TE+pUSRpPezgnX053/b TpodM5kEqvUQ2Hq0wj73THxqekOxAzf67J067G1WqsrjpxwV62KqWsVp5PEFtdgWqp JbRUQFTlkKe6W2RgyiB3ykD57kpwIANIGbAFBhsqD3RiMvRx7rnTrS+6cYkvidF3Ys FNGEb/ozzX1VqM0MpQ/flBOYqy39n+gU5ikatFt6UfGzUF7FsO6wRJtuli47SkXNcs C97Fx13YCB+YbmdaHvVe+fgqE6hFCTQMtQ7o/leWjIES5boL0lfnePso+qEW2Prx+j Jt4w64sLzxNIw== Received: by mercury (Postfix, from userid 1000) id 5F99A1060FD4; Sun, 12 Mar 2023 23:31:17 +0100 (CET) Date: Sun, 12 Mar 2023 23:31:17 +0100 From: Sebastian Reichel To: Zheng Wang Cc: njavali@marvell.com, mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com Subject: Re: [PATCH v2] power: supply: da9150: Fix use after free bug in da9150_charger_remove due to race condition Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230311174650.3979517-1-zyytlz.wz@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2apthxtojbiu375y" Content-Disposition: inline In-Reply-To: <20230311174650.3979517-1-zyytlz.wz@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312223117.8pAgfb6ESz2m0zUql53vrR_LwXOkoanS1pci6muBVNs@z> --2apthxtojbiu375y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Mar 12, 2023 at 01:46:50AM +0800, Zheng Wang wrote: > In da9150_charger_probe, &charger->otg_work is bound with > da9150_charger_otg_work. da9150_charger_otg_ncb may be > called to start the work. >=20 > If we remove the module which will call da9150_charger_remove > to make cleanup, there may be a unfinished work. The possible > sequence is as follows: >=20 > Fix it by canceling the work before cleanup in the da9150_charger_remove >=20 > CPU0 CPUc1 >=20 > |da9150_charger_otg_work > da9150_charger_remove | > power_supply_unregister | > device_unregister | > power_supply_dev_release| > kfree(psy) | > | > | power_supply_changed(charger->usb); > | //use >=20 > Fixes: c1a281e34dae ("power: Add support for DA9150 Charger") > Signed-off-by: Zheng Wang > --- > v2: > - fix wrong description in commit message and mov cancel_work_sync > after usb_unregister_notifier suggested by Sebastian Reichel > --- Thanks, queued to power-supply's fixes branch. Please make sure you send your patches to the correct destination next time (linux-scsi should be linux-pm). -- Sebastian > drivers/power/supply/da9150-charger.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/power/supply/da9150-charger.c b/drivers/power/supply= /da9150-charger.c > index 14da5c595dd9..a87aeaea38e1 100644 > --- a/drivers/power/supply/da9150-charger.c > +++ b/drivers/power/supply/da9150-charger.c > @@ -657,6 +657,7 @@ static int da9150_charger_remove(struct platform_devi= ce *pdev) > =20 > if (!IS_ERR_OR_NULL(charger->usb_phy)) > usb_unregister_notifier(charger->usb_phy, &charger->otg_nb); > + cancel_work_sync(&charger->otg_work); > =20 > power_supply_unregister(charger->battery); > power_supply_unregister(charger->usb); > --=20 > 2.25.1 >=20 --2apthxtojbiu375y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOUrUACgkQ2O7X88g7 +povSw/+MDk1ALJfK5t/+F826SwdME6Ocl1W3YoVM72Xj9NTd41PQleGKapzNrpD qB3rp8OQw+io3QvJDgk8WfMkdIXe4QwV0YB/k/iVkWeoEXLbg5GsbOD7aS4P4G6K ANW629FZxD1ZzpWMCQMIw1/oYYTTxH25evgGOUGQMwSqxNbYpUbRwVWY13GFnX5f qQ7yKIHeHUcIMaKWItPhXNzg+CtLwLjRARHYQHkhSyPvR87W/90fRQbUU62CokYi qyMEVrAQoeMKjh3SbSnpfG3/CcRXNzIFNnX9+ZPy/14GlJmo5LVvYj8XLYTdQLCT CfbpbJCPg6RzIpHAukD0TK5LdKvk3jaxafZS4zsWqw2NBFMdAzW+w6rsjsrN7Zag +1hADykMvh78F+jr4+E9cOcTQlyHNqv+xsUzZq01bN7NUoYdnuUXDII6aUVQN/d+ mrvcR+6Nz0m8axEtYvSF4iwq+eIf3L7wLTzvcSZ0OWxUAbPI0dPNyAzbDXtKjEtE 4tQZxnWlw6Qf+i303/JxCjv8WSpkXpqeh/pdM94b7b7HLAqZr/HfTruz6N+niwOx NzgR6Xx5pwrXOlflNU/ighnuNOtxtgHaVnbu7Uf6hvEzx7sRtZ05YTSrm4Fxr4ol a664C/+1N5qyPmvTTKyUpFcZAqCSnT8skK5PeYcZ6oin+GipBZk= =j4ZU -----END PGP SIGNATURE----- --2apthxtojbiu375y-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0C5C74A4B for ; Sun, 12 Mar 2023 22:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230398AbjCLWdL (ORCPT ); Sun, 12 Mar 2023 18:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbjCLWdJ (ORCPT ); Sun, 12 Mar 2023 18:33:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A4C2E195; Sun, 12 Mar 2023 15:33:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABA3F61015; Sun, 12 Mar 2023 22:33:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1E16C433D2; Sun, 12 Mar 2023 22:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678660387; bh=nBc93sXiAYACx3pnXIOgQiKft2dOHkoo3DbtvkGwrhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VLunBXe9caBebWSZsNdpGBdxw9FDt8RDwFx+3LLZZYdgRhf7yrxVwLreCV63Uktwa GrlzrdCFnTa3CHvPt2nAzRRcqPyYi4F9eo4QpilzTvdRhnyTUKBJBuQ2qZZWFBiwZu J1xFbemJyogYZf1ooclZSoItUdjzgS19i2FllucOEmEuDPjhdtKGq6lzunyvJaKiaX 3c3zwFH7UPuAz7g1U4MOFDMGamFwxpLSaw7mvf0tEtHgu2h+WvEvdOrmcK2MFLjgNX hAEbN2JCXoFx46vOq5jtFb3tYmOa+4SYeRZCAPQZpSgL9MbK+EmOpWD+AsnlV3EJTC iACg0W264zEIg== Received: by mercury (Postfix, from userid 1000) id 45E5D1060FD4; Sun, 12 Mar 2023 23:33:04 +0100 (CET) Date: Sun, 12 Mar 2023 23:33:04 +0100 From: Sebastian Reichel To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230310200652.19926-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rwm4btwbb7qrunf7" Content-Disposition: inline In-Reply-To: <20230310200652.19926-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312223304.-LiVxaLpc_cYwu8RnvC_dBuzfRBKlpB3fiREy3zVjwc@z> --rwm4btwbb7qrunf7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 10, 2023 at 09:06:52PM +0100, Krzysztof Kozlowski wrote: > The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends > on OF thus the driver is OF-only. It's of_device_id table is built > unconditionally, thus of_match_ptr() for ID table does not make sense. >=20 > Signed-off-by: Krzysztof Kozlowski > --- Thanks, queued to power-supply's for next branch. -- Sebastian > drivers/power/reset/qcom-pon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-po= n.c > index 16bc01738be9..ebdcfb28c4a0 100644 > --- a/drivers/power/reset/qcom-pon.c > +++ b/drivers/power/reset/qcom-pon.c > @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver =3D { > .probe =3D pm8916_pon_probe, > .driver =3D { > .name =3D "pm8916-pon", > - .of_match_table =3D of_match_ptr(pm8916_pon_id_table), > + .of_match_table =3D pm8916_pon_id_table, > }, > }; > module_platform_driver(pm8916_pon_driver); > --=20 > 2.34.1 >=20 --rwm4btwbb7qrunf7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOUx8ACgkQ2O7X88g7 +pp8Qg/9G1xja6Ebkw+FSgJqDaWl6nsDyIYfZU9jLtyj3lQ6jUcSBmcj/qDcaJNr 7HcVLK3foFmDrwPzU+ETv18OBnKRn2yZ+WNZoWO9MjUoNiYs/4mevKzgdKmsqwdn nSGU9zOG4IHlVKBUkiPQUVPu+k0gxRX8r9aMuCMcdnhDPDpy3h4e2WqG5N5JwnEE jXhVFHM/y6qSdpVvyI4iHluMy+Ws5jnCO7aIuQltbzwVyHWyAdSMU/gAsfF1HivM UaBd523CxX0GtNz48QdrY7NgzsUKA1DvSez/z90maxzE9Wem3rOXgpq/i86GbDhB JB0junRCZgitQp6hsWL/e0nUPxWTWoC7NMvblniMts9NUAkHA/IWMkGkaO6wrwPG q1ZxiOloJxYgW5penPyJNFYZhLdAuYF8FC3ovV2raA0vsXC+0Hu+rroEDG3UbUqV xBa4SclUQm3lspe6+1ItYc51h9MUYyR8W90Qc1m2JuX6iLCHmswYfU2ICNjNqpC2 2cp2Aiqw3cjQHfxvuVBiQQ2t2r+UXuU+pen0LwLUJGT909V3RvGbuNJGhahyDuBD 6HKBHI5CBOJv2/J5HCg6Tc4ojIiBsq4RBhFXgazXB/QfnfwfAW8PcALAv2/ASr8n 8ku4E3Fuc0xbL1Bg+O5xL+Abijf+l7oSq7c3HIQ3CR50OsEA9PI= =Vt6K -----END PGP SIGNATURE----- --rwm4btwbb7qrunf7-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DD0C6FD19 for ; Sun, 12 Mar 2023 22:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjCLWgP (ORCPT ); Sun, 12 Mar 2023 18:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjCLWgO (ORCPT ); Sun, 12 Mar 2023 18:36:14 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D89132C0; Sun, 12 Mar 2023 15:36:13 -0700 (PDT) Received: from mercury (unknown [185.254.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 479106602F13; Sun, 12 Mar 2023 22:36:12 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678660572; bh=SJfzew+2aNS9FiIgtBkSq0NhB8lkWhj5GA46wF1nmm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N59x72DP9HqD2W0GdgZTY4vqUlG4/JKai02N39lSD4QHHyBoXGr9RIVKk2hMorMwn d9GBeNPUeqOuVzxhWfjIzmRQDMtGO0nE/qOkP8d/XT7sD716x1nw1ksPbHqkyWpuaW AOfR9z8477Z7z4WXubmF5iLWwUOQQeRxxwJas36YItznPwqU3pnO6loPXBlAyfBy21 BOnP22jwEn5jD9cbT+GA07GVMC4uSdbboP8Z4hgJVhc9RKhypmbAnm5YeXeRx/iuIb 2m9udTzJz8bQzQM0sttQchSW7IMyAURcerMT2kl0SEaCti/CIsTXICRvqfuztHRdig nbhw+UD7XXKOg== Received: by mercury (Postfix, from userid 1000) id D3E081060FD4; Sun, 12 Mar 2023 23:36:09 +0100 (CET) Date: Sun, 12 Mar 2023 23:36:09 +0100 From: Sebastian Reichel To: Rob Herring Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: charger-manager: Use of_property_read_bool() for boolean properties Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230310144735.1546888-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="esdwyao7whnqopbb" Content-Disposition: inline In-Reply-To: <20230310144735.1546888-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312223609.hELI-2zRLorgsRkJTniUWaiVApQG3trlKr37HvqGWio@z> --esdwyao7whnqopbb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 10, 2023 at 08:47:35AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. > Convert reading boolean properties to to of_property_read_bool(). >=20 > Signed-off-by: Rob Herring > --- Thanks, queued. -- Sebastian > drivers/power/supply/charger-manager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/suppl= y/charger-manager.c > index c9e8450c646f..5fa6ba7f41e1 100644 > --- a/drivers/power/supply/charger-manager.c > +++ b/drivers/power/supply/charger-manager.c > @@ -1331,7 +1331,7 @@ static struct charger_desc *of_cm_parse_desc(struct= device *dev) > of_property_read_string(np, "cm-thermal-zone", &desc->thermal_zone); > =20 > of_property_read_u32(np, "cm-battery-cold", &desc->temp_min); > - if (of_get_property(np, "cm-battery-cold-in-minus", NULL)) > + if (of_property_read_bool(np, "cm-battery-cold-in-minus")) > desc->temp_min *=3D -1; > of_property_read_u32(np, "cm-battery-hot", &desc->temp_max); > of_property_read_u32(np, "cm-battery-temp-diff", &desc->temp_diff); > --=20 > 2.39.2 >=20 --esdwyao7whnqopbb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOU9kACgkQ2O7X88g7 +pqlDg//Z2CepETxVSTBcXjJs98lElws+51NmKJOfFNnoUvbIw/+lMANJ4AYp+32 yMlk+QIlgng9aRunNPYGXDAkjB3grwZ4sbw3DelADFpDrnz4Q9oPujJJTTbocxVe Brxk5h0fnBcZevhz8cGP+/mX9iB04eXjLaPwaNsTIi3X0cfNTnZ9g0ghr5OZqMUB I2QSleKatJRp4XuPzE1sKE+ZJN9IFuD7A0twngv4MOwhbh6ysQYc+PTam1l0Up0J UcMB/s5NIb/xEbeP96ESsQ4QLXfCtYRMxITVzpMTn0BacuX6fjNOJhmeQCuehBtG K62CbJjhGPMs1/CLyYw4WcJa+1o0lwr1UA/i0wjBAkSgrkEbWMSrNZYpjWLpRO6y EjdZwMxMSbWy6GWTjl6FkNnmX+R47MNZflwOFVXkNbbnDsu//xhU63gbavdzM86K 1PaZSIBP8keA+LQwySnLiJuqy/LO6G7HztuaBqvlh/DH/3hIPliEbA8knJFPNMRI JvCQYX3rb3/V1/g+//nZruUlolQ1zcIVxLzXFMaFWgi6vRp/UhgE8saAu29CdeMA 2q9JAZx8md0+G7UG02qUUZtExeFr06uF9TJ5MWk+hBueI8MrQ+S815WSBd5I8a3F kQEbjZ2WWk+vHnY9DK09mjpXg39dSsd//pjHv/Gpt68TuVtHk+Q= =Vnoq -----END PGP SIGNATURE----- --esdwyao7whnqopbb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97DAC6FD1F for ; Sun, 12 Mar 2023 22:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbjCLWqr (ORCPT ); Sun, 12 Mar 2023 18:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjCLWqq (ORCPT ); Sun, 12 Mar 2023 18:46:46 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D389A30B2B; Sun, 12 Mar 2023 15:46:45 -0700 (PDT) Received: from mercury (unknown [185.209.196.169]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 882006602F13; Sun, 12 Mar 2023 22:46:44 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678661204; bh=MTii68UXbEJyigv+rC2VJmnMysj4S0AVTawLMJCZCS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nsnYAxtv9e6JLpZfb5Dh6vIuxwGi6XBcOoi+cGhRpXjQGEOi4v6Na7aPxWkoeMzjq +VMB3XsdTBJWlqX71AXg4hfnWbQVVyh9rftK/Q/x/s7CG72QEfgoAr1TdA7ERK88X0 eSC1ISYLVd/6gu/EtBrG2/Hlx5iV7OSzUUt1bcsAPl0ZXWiKL69+lMhjYjEMe3rzlH jhoAIsr8235La7BGG9diUcAvZq8F6GOzo8x4JrtmfmAZUTK2nJ3Rd11geGW2ylsfAi 8Azn8zp40SVP/sEk85IWOfnibsk90JaQnwsMuas1EPYA8qZkzPxiiA3vhvRZYWnL/Y v2efZhdtX2jOw== Received: by mercury (Postfix, from userid 1000) id 0D2C41060FD4; Sun, 12 Mar 2023 23:46:42 +0100 (CET) Date: Sun, 12 Mar 2023 23:46:41 +0100 From: Sebastian Reichel To: Bjorn Andersson , Bjorn Andersson Cc: Arnd Bergmann , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Konrad Dybcio , linux-pm@vger.kernel.org Subject: Re: drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse: incorrect type in initializer (different base types) Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <202303110050.1EF6YVC5-lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dx3tdltyysw5wcwj" Content-Disposition: inline In-Reply-To: <202303110050.1EF6YVC5-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312224641.3WbzBbWetIFiN84PACfDGceXqfqzrPekIe6x9BQK3Xo@z> --dx3tdltyysw5wcwj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Bjorn, Can you please send a follow up patch for the sparse warnings in qcom_battmgr [0]? It looks like there are two issues: 1. qcom_battmgr_update_request.battery_id is u32 instead of __le32 2. qcom_battmgr_enable_worker is missing cpu_to_le32() when building struct qcom_battmgr_enable_request [0] https://lore.kernel.org/all/202303110050.1EF6YVC5-lkp@intel.com/ > sparse warnings: (new ones prefixed by >>) > >> drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] battery_id @@ got restricted __le32 [usertype] @@ > drivers/power/supply/qcom_battmgr.c:357:31: sparse: expected unsigned int [usertype] battery_id > drivers/power/supply/qcom_battmgr.c:357:31: sparse: got restricted __le32 [usertype] > drivers/power/supply/qcom_battmgr.c:369:31: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] battery_id @@ got restricted __le32 [usertype] @@ > drivers/power/supply/qcom_battmgr.c:369:31: sparse: expected unsigned int [usertype] battery_id > drivers/power/supply/qcom_battmgr.c:369:31: sparse: got restricted __le32 [usertype] > >> drivers/power/supply/qcom_battmgr.c:1285:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected restricted __le32 [usertype] owner @@ got int @@ > drivers/power/supply/qcom_battmgr.c:1285:30: sparse: expected restricted __le32 [usertype] owner > drivers/power/supply/qcom_battmgr.c:1285:30: sparse: got int > >> drivers/power/supply/qcom_battmgr.c:1286:29: sparse: sparse: incorrect type in initializer (different base types) @@ expected restricted __le32 [usertype] type @@ got int @@ > drivers/power/supply/qcom_battmgr.c:1286:29: sparse: expected restricted __le32 [usertype] type > drivers/power/supply/qcom_battmgr.c:1286:29: sparse: got int > >> drivers/power/supply/qcom_battmgr.c:1287:31: sparse: sparse: incorrect type in initializer (different base types) @@ expected restricted __le32 [usertype] opcode @@ got int @@ > drivers/power/supply/qcom_battmgr.c:1287:31: sparse: expected restricted __le32 [usertype] opcode > drivers/power/supply/qcom_battmgr.c:1287:31: sparse: got int -- Sebastian --dx3tdltyysw5wcwj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOVksACgkQ2O7X88g7 +por+A//RI7dYm0hzeTkTcP+T3pb09fz6dwlsWcoLmzi00a5gu2EhtN/UQjhAqEN 1slZ9k3PIfBzYFERJBSeIct6r9ysd8WP2e2XrL8ItMN/aGrdh9mYkd7l6vOZkrlb b/aNyO1aNPVik+qZOzy3fgDLIObbQxfPzHZ9bBQNBycp4qMtLAQ2oS7FcwTlrJ18 pHhIKQ87kpf/u3rzR6V9iQguIoTgCKBKAg2bNUVjOveKKA2cmzRoLoB5R+Fc8Oke VOlCKUYttwXB+zYTTSoPIxJIOy32kFNiLFt10F3BJbS2SdhmdmWz7zC/VKlJB0Eu oVq8IvDzjBKWpT/+UB1c8lLBj8HJ52AT0J4VoweM3P+JWPuibhSx24FvsSEjPYzg j5bRxr0mlHrK35hyTRGAYvOIInX7REaMYsC0Cgup5z1GmA6zQdPptsnSTURCOOxU o+5H6qe3/++GqWXrd8xuoiXh5bzRVoLCo/fNg32536tdwMpQ2MkxSRZCaSUzCVbc twP75tMqE1iI0bgybNHbgsjMxueh1WnGEdAYgs+NXIAx1FGc5oAjj8AAeuN0L/ou vY/q20xEeXhb444Wc6ITadByYGsa9q/SQjglklJ98aRgVaus+oQn2H+RauL2HQSi zzaQ5D6AB6XM5G7v5Txyh6Wq4wF7YSW+RJKj5ZyKHiNBsMfQX0o= =bG3l -----END PGP SIGNATURE----- --dx3tdltyysw5wcwj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F7FC6FD19 for ; Sun, 12 Mar 2023 22:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbjCLWuU (ORCPT ); Sun, 12 Mar 2023 18:50:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjCLWuT (ORCPT ); Sun, 12 Mar 2023 18:50:19 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E5BE32E5D; Sun, 12 Mar 2023 15:50:17 -0700 (PDT) Received: from mercury (unknown [185.254.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 33D7D6602F13; Sun, 12 Mar 2023 22:50:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678661416; bh=M5+nSc1iWkLndW4q1iULDQ+SKPeVQwicOS2p4YvXLMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=StDhfmUJlXV+oPEgIlhee7wlWGQ6o8gHfe245ShrtwlQQSeDlNj8lMEEe+JhPF0Ri WexywZk9xrkQ+ZkA3FPcd7IFjbAD0iHtHgnxKG7JfQQs+XZXJocn1wiG1d7hldpAPs vlvmdabSOEoRFcxoN445VC5pQ/AIjtfSJZ799oYvvWZmIq6IS1//twH1MdgSt5Plnj 9MJ1OEkve8JRVIcdi1SwbZQa4LvxfIe171txSoVAvrXLHyLfP2VtZsXA/H36fhShCJ eLJf0QU8YCoCNHxh9xFxY2UKToUIiguOaWPTxXtES5wszBH9+lx4TehxC8huRaaSGu GqVu+qYfCJGVg== Received: by mercury (Postfix, from userid 1000) id 8912A1060FD4; Sun, 12 Mar 2023 23:50:13 +0100 (CET) Date: Sun, 12 Mar 2023 23:50:13 +0100 From: Sebastian Reichel To: Hermes Zhang Cc: kernel@axis.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: bq256xx: Support to disable charger Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230309064104.79005-1-chenhuiz@axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qoe3tbzunmzj3cl4" Content-Disposition: inline In-Reply-To: <20230309064104.79005-1-chenhuiz@axis.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230312225013.jE9ZCgXGESu6_6YAsZ4DtvdgdgYU6WUVspvNwES70dQ@z> --qoe3tbzunmzj3cl4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Mar 09, 2023 at 02:41:03PM +0800, Hermes Zhang wrote: > To be able to control the charging process flexible, we need to able to > disable the charger. This commit will allow to disable the charger by > "echo 1 > /sys/class/power_supply/bq256xx-charger/charge_type" > (1 =3D POWER_SUPPLY_CHARGE_TYPE_NONE) and enable the charger by set it to > 2/3 (POWER_SUPPLY_CHARGE_TYPE_TRICKLE/POWER_SUPPLY_CHARGE_TYPE_FAST) >=20 > Signed-off-by: Hermes Zhang > --- Thanks, queued. -- Sebastian > drivers/power/supply/bq256xx_charger.c | 40 ++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) >=20 > diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/suppl= y/bq256xx_charger.c > index 9cf4936440c9..e624834ae66c 100644 > --- a/drivers/power/supply/bq256xx_charger.c > +++ b/drivers/power/supply/bq256xx_charger.c > @@ -70,6 +70,9 @@ > #define BQ25611D_VBATREG_THRESH_uV 4290000 > #define BQ25618_VBATREG_THRESH_uV 4300000 > =20 > +#define BQ256XX_CHG_CONFIG_MASK BIT(4) > +#define BQ256XX_CHG_CONFIG_BIT_SHIFT 4 > + > #define BQ256XX_ITERM_MASK GENMASK(3, 0) > #define BQ256XX_ITERM_STEP_uA 60000 > #define BQ256XX_ITERM_OFFSET_uA 60000 > @@ -259,6 +262,7 @@ struct bq256xx_device { > * @bq256xx_set_iterm: pointer to instance specific set_iterm function > * @bq256xx_set_iprechg: pointer to instance specific set_iprechg functi= on > * @bq256xx_set_vindpm: pointer to instance specific set_vindpm function > + * @bq256xx_set_charge_type: pointer to instance specific set_charge_typ= e function > * > * @bq256xx_def_ichg: default ichg value in microamps > * @bq256xx_def_iindpm: default iindpm value in microamps > @@ -290,6 +294,7 @@ struct bq256xx_chip_info { > int (*bq256xx_set_iterm)(struct bq256xx_device *bq, int iterm); > int (*bq256xx_set_iprechg)(struct bq256xx_device *bq, int iprechg); > int (*bq256xx_set_vindpm)(struct bq256xx_device *bq, int vindpm); > + int (*bq256xx_set_charge_type)(struct bq256xx_device *bq, int type); > =20 > int bq256xx_def_ichg; > int bq256xx_def_iindpm; > @@ -449,6 +454,27 @@ static int bq256xx_get_state(struct bq256xx_device *= bq, > return 0; > } > =20 > +static int bq256xx_set_charge_type(struct bq256xx_device *bq, int type) > +{ > + int chg_config =3D 0; > + > + switch (type) { > + case POWER_SUPPLY_CHARGE_TYPE_NONE: > + chg_config =3D 0x0; > + break; > + case POWER_SUPPLY_CHARGE_TYPE_TRICKLE: > + case POWER_SUPPLY_CHARGE_TYPE_FAST: > + chg_config =3D 0x1; > + break; > + default: > + return -EINVAL; > + } > + > + return regmap_update_bits(bq->regmap, BQ256XX_CHARGER_CONTROL_0, > + BQ256XX_CHG_CONFIG_MASK, > + (chg_config ? 1 : 0) << BQ256XX_CHG_CONFIG_BIT_SHIFT); > +} > + > static int bq256xx_get_ichg_curr(struct bq256xx_device *bq) > { > unsigned int charge_current_limit; > @@ -915,6 +941,12 @@ static int bq256xx_set_charger_property(struct power= _supply *psy, > return ret; > break; > =20 > + case POWER_SUPPLY_PROP_CHARGE_TYPE: > + ret =3D bq->chip_info->bq256xx_set_charge_type(bq, val->intval); > + if (ret) > + return ret; > + break; > + > default: > break; > } > @@ -1197,6 +1229,7 @@ static int bq256xx_property_is_writeable(struct pow= er_supply *psy, > case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT: > case POWER_SUPPLY_PROP_STATUS: > case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT: > + case POWER_SUPPLY_PROP_CHARGE_TYPE: > return true; > default: > return false; > @@ -1286,6 +1319,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq256xx_set_term_curr, > .bq256xx_set_iprechg =3D bq256xx_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ2560X_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > @@ -1316,6 +1350,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq256xx_set_term_curr, > .bq256xx_set_iprechg =3D bq256xx_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ2560X_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > @@ -1346,6 +1381,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq256xx_set_term_curr, > .bq256xx_set_iprechg =3D bq256xx_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ2560X_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > @@ -1376,6 +1412,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq256xx_set_term_curr, > .bq256xx_set_iprechg =3D bq256xx_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ2560X_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > @@ -1406,6 +1443,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq256xx_set_term_curr, > .bq256xx_set_iprechg =3D bq256xx_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ25611D_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > @@ -1436,6 +1474,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq25618_619_set_term_curr, > .bq256xx_set_iprechg =3D bq25618_619_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ25618_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > @@ -1466,6 +1505,7 @@ static const struct bq256xx_chip_info bq256xx_chip_= info_tbl[] =3D { > .bq256xx_set_iterm =3D bq25618_619_set_term_curr, > .bq256xx_set_iprechg =3D bq25618_619_set_prechrg_curr, > .bq256xx_set_vindpm =3D bq256xx_set_input_volt_lim, > + .bq256xx_set_charge_type =3D bq256xx_set_charge_type, > =20 > .bq256xx_def_ichg =3D BQ25618_ICHG_DEF_uA, > .bq256xx_def_iindpm =3D BQ256XX_IINDPM_DEF_uA, > --=20 > 2.30.2 >=20 --qoe3tbzunmzj3cl4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQOVyUACgkQ2O7X88g7 +pq18A//fKNA9oreZmLLVfBcno87KV1EzcerqLASBIhTm71l67H+bcJlrfj6MtiN JwZljO5B0OBpd0VgbSCgPZDxrdvcOkRnK7d97F9Ld214DngO1MWIlknrEJc2iwCX KQtQS0x8E2FSu/ac4jg7UnnL7psJvWct65uy5FNNpFpvUJQBOP3SNyb/8mEfO3rk ImuZn4+B6j7WJzM3/qGK0+5VdilllFmsGvtvCUcChWkOY1PvD4BLJnTbEdGbEZ5J wWFsDoAXUQOqCPV0Hqt8+FRwH/tAduFqzURo2epVBONefJ3qZgS783aLfD3ALqUQ o0RT4Y8UPFJs81nJlubbg3BGTDETsD33XTJHZznB5WbVTTWueOh/JpHuRzt+v9UG J0FjNjex5/kMHueBOd5NduS+GRK8G8Hv3OXURms/2Y4r5YpSLjgOI9VZc7OM8mZl NVBIdTEr5xg0jE2TryefsnXdPcB56LVB985Qz7UBAXXVxrtIRQ9AcTpaEXhPoodb xrzsQiq4WK5h+BPJiQCc3N10LM5PAExFCqLIKZNTF2vZptsjfBKAwqauqOZWIxlQ rke3rMoR3KIgzv7gv8odv46oMdznfW37igg3ctQG/BuFHNOihfFttwA/ij4gFIpC ayIWS2ERpK1HxEFJk+bWOorZJtKkZtoziwhjhgrWP0bUNeSzBIQ= =e7OE -----END PGP SIGNATURE----- --qoe3tbzunmzj3cl4-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0204C6FD19 for ; Mon, 13 Mar 2023 23:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbjCMXRc (ORCPT ); Mon, 13 Mar 2023 19:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjCMXRb (ORCPT ); Mon, 13 Mar 2023 19:17:31 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 758997F015; Mon, 13 Mar 2023 16:17:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CB530CE1290; Mon, 13 Mar 2023 23:17:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3DA5C433D2; Mon, 13 Mar 2023 23:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678749445; bh=rkf+w2R5U9yIyPxz2FD9JcXK7xhs8LnPgBEvZWq+PXw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p4uiqAV+1Dom/tq2BBK/v5VM0GdAD+C72IHMEwHM9H8xKqSslhSoJJWeWm9kUAp68 FqEqZXgcCQfhwmRRvRxuG6APBkfypGak6gjl5658yMjV+vJxytUgyvyE8aJOy4c4RS 5ZSwkfobbVqFcrFdDTr46j9cgzSbY6IKXedhVCswu9hjlObWlFucvzo5bwzVD4FzZf vBm5sJc+4OloxUOZ9fZkHxwst0a1NPq1SGoWXUldtCJmaWZ1a7SpGAIq5qcdTJO8t0 TFxKgE7Wg15Qw3sN0us/GNeR27WazFQn89Mec3R4UpKzeF04WQRuXXQb5+O7029qb0 RVIIdll/Fkv6A== Received: by mercury (Postfix, from userid 1000) id 172041061E59; Tue, 14 Mar 2023 00:17:19 +0100 (CET) Date: Tue, 14 Mar 2023 00:17:19 +0100 From: Sebastian Reichel To: Linus Walleij Cc: Matti Vaittinen , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling Message-ID: <1fdf00a0-4830-465a-801c-147472fdcd22@mercury.local> References: <20230309225041.477440-1-sre@kernel.org> <20230309225041.477440-5-sre@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7uyvyepd44usvzdp" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20230313231719.0PnUNByjU_RIQ_mlLHgAvtB396axPCZSxCBDnAWkpj0@z> --7uyvyepd44usvzdp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 10, 2023 at 09:23:06AM +0100, Linus Walleij wrote: > On Thu, Mar 9, 2023 at 11:50=E2=80=AFPM Sebastian Reichel wrote: >=20 > > power-supply properties are reported in =C2=B5V, =C2=B5A and =C2=B5W. > > The IIO API provides mV, mA, mW, so the values need to > > be multiplied by 1000. > > > > Signed-off-by: Sebastian Reichel >=20 > Fixes: tag? > Cc: stable@vger.kernel.org >=20 > Reviewed-by: Linus Walleij >=20 > This code can not have seen much testing. There is no mainline board using this driver and I think there never was one. I did add a Fixes tag now, but its probably not worth any backporting trouble considering it has no users. -- Sebastian --7uyvyepd44usvzdp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQPrvcACgkQ2O7X88g7 +pr+5g//boqvVUatIQJz3AYJDUC/o9r62m7SjGB5Zumh4KgV0KuIQmVqm3yxiW6u o3Gxo+SrJw5aUmUceXIhjzueK34uaZm9ncHeIch/IcwyepZKvPBEz4o5+hOwwfG7 b1nDx93sQsOkB2mOiCFGID6DB8M6slRagc6qIbk01lkKppWhTqxnUh1yvG1nURZo FaNqXkB8KJbQglknVOZZ4nVsJnkt8jj0L3H5LfoHaSEBJtd48j/22kVfHI4KCdo3 Shyxh6B8Z+RDPxWmqGEOQd9IrCPxje07M2mq0p1XG4gARUtFc8oS+kWW15Jv2W9x DDy5HlPvPQ2legMlLTjsYWcDBDmO8TU1Sj/aTi6h+lV18fi2nfC/FSpUBXHW/tfI 1/KCzDKziTMxRPAjVa4l+AjJCtOW48uTc1r+OxXpSBjQ4Tj91f+xLR2pgtq7Fvv9 E3uNigw8WDlfzrvjFXKr5Mrt/mixYexfmfm9hRdAkhs7vMSkhnyDMGgUEylHSYtD 6ZzLvCrF1ClMSFfN54wgk596TLM1QFIO/LZvc4/820MuprXpGqCK9OLbcyGt9OdW PrHSQmdCFmW+u6YGMurTeJMaxTw0fHK6QibluRvZUbLqR974sRJ4ilVfVruMEBNS yz1R8ifTVTACoJoKFKcWKp+HLjrTJSP/4yKcoxCoo2doUMyrbXs= =+FR2 -----END PGP SIGNATURE----- --7uyvyepd44usvzdp--