From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: Re: uhci-hcd suspend/resume under the new driver model Date: Wed, 16 Mar 2005 13:09:33 -0800 Message-ID: <200503161309.34142.david-b@pacbell.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============89296233653490908==" In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces-qjLDD68F18O7TbgM5vRIOg@public.gmane.org Errors-To: linux-pm-bounces-qjLDD68F18O7TbgM5vRIOg@public.gmane.org To: Alan Stern Cc: Bernard Blackham , ncunningham-3EexvZdKGZRWk0Htik3J/w@public.gmane.org, Linux-pm mailing list , Pavel Machek List-Id: linux-pm@vger.kernel.org --===============89296233653490908== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 16 March 2005 7:45 am, Alan Stern wrote: > On Wed, 16 Mar 2005, Bernard Blackham wrote: > > > I haven't tried David's patch yet - the only differences are it > > seems to use a slightly different order, and also calls > > pci_set_master. I'll give that a spin later today combined with and > > without yours to see what works reliably. > > The missing pci_set_master in my patch probably explains the errors you > got. > > David's patch doesn't make all the necessary changes that my patch does. > In particular it doesn't avoid doing pci_restore_state when there was no > prior pci_save_state, so it will continue to exhibit some of the problems > we were seeing before. Well, as I said it wasn't quite ready for prime time. It's possible that would explain some other USB related resume issues. I'm not sure why your patch is so big/complex t hough... --===============89296233653490908== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline --===============89296233653490908==--