From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Nested suspends; messages vs. states Date: Thu, 24 Mar 2005 10:59:10 +0100 Message-ID: <20050324095910.GD1354@elf.ucw.cz> References: <1111540913.16224.43.camel@gaston> <1111548664.16201.63.camel@gaston> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============11618048187356456==" In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces-qjLDD68F18O7TbgM5vRIOg@public.gmane.org Errors-To: linux-pm-bounces-qjLDD68F18O7TbgM5vRIOg@public.gmane.org To: Patrick Mochel Cc: Linux-pm mailing list List-Id: linux-pm@vger.kernel.org --===============11618048187356456== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! > > > > Note that rather than enter_state, I'd rather just have a function > > > > pointer enter_this_state in the driver state array ... > > > > > > Wouldn't that imply a different ->enter_state() method for each system > > > state? > > > > one enter state method for each driver state. If the driver has one > > enter state for each system state, then go for it. > > Two things: > > 1) I meant just 1 ->enter_state() entry point for the core to call. It > won't call a different function depending on the state; it will leave it > up to the driver to determine what state to enter/what function to call. > Internally (or in its bus core), is where the array of enter_state() > methods would reside. Do you agree? > > 2) The system states are totally dependent on the platform. I don't see > how we could have a sane array that encapsulates every possible system > state. Thoughts? Seems to me that suspend-to-RAM and suspend-to-DISK make sense, and cover 90% of what people want to do. Add "standby" for "fast suspend-to-RAM" and you cover even ARM. I'd say that's good enuogh. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! --===============11618048187356456== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline --===============11618048187356456==--