Re: Re: [RFC] Driver States

Pavel Machek
2005-04-08T10:31:42Z

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi!

> > > > You have a few things here that can easily conflict, and that will be
> > > > developed at different paces. I like the direction that it's going, but
> > > > how do you intend to do it gradually. I.e. what to do first?
> > >
> > > I think the first step would be for us to all agree on a design, whether
> > > it be this one or another, so we can began planning for long term
> > > changes.
> > >
> > > My arguments for these changes are as follows:
> >
> > 0. I do not see how to gradually roll this in.
> >
> > > 4. Having responsibilities at each driver level encourages a
> > > layered and object based design, reducing code duplication and
> > > complexity.
> >
> > Unfortunately, you'll be retrofiting this to existing drivers. AFAICS,
> > trying to force existing driver to "layered and object based design"
> > can only result in mess.
> > Pavel
>
> Fair enough. How does this sound? I'd like to add "*attach" and
> "*detach" to "struct device_driver". These functions would act as one
> time initializers and decontructors. Then we could rename "*probe" to
> "*start", and "*remove" to "*stop", which should be rather trivial to

I do not think you'll find rename across all the drivers easy. You
could get away with "I create start, and if it does not exist, probe
is called instead", but you need pretty good justification for that, too.

Pavel
--
Boycott Kodak -- for their patent abuse against Java.