From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: Re: freeze_processes questions Date: Thu, 7 Apr 2005 23:03:15 +0200 Message-ID: <200504072303.15502.rjw@sisk.pl> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============28513577988681771==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: Pavel Machek Cc: linux-pm@lists.osdl.org, Nigel Cunningham List-Id: linux-pm@vger.kernel.org --===============28513577988681771== Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, On Thursday, 7 of April 2005 22:00, Alan Stern wrote: > On Thu, 7 Apr 2005, Rafael J. Wysocki wrote: ]--snip--[ > > > If that means waiting more than 10 seconds or so, you should just give up. > > > Return an error and put a message in the log saying something like "Can't > > > suspend because process XXX is busy". > > > > OK, that's what we do now. Except that IMO we should clear the PF_FREEZE flag > > for this process and do recalc_sigpending() for it after we give up, because > > otherwise it will enter the refrigerator sooner or later and it will stay there. > > Alternatively, we can disable the "freezing loop" in refrigerator() as soon as > > thaw_processes() is started. Also, we can avoid setting PF_FREEZE for > > processes in TASK_UNINTERRUPTIBLE, but count them as "freezable". Etc. > > Yes, all the necessary cleanup steps should be taken. Pavel, which approach do you like most? Rafael -- - Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland" --===============28513577988681771== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline --===============28513577988681771==--