Re: [PATCH] Don't explode on swsusp failure to find swap

Benjamin Herrenschmidt
2005-05-31T14:45:06Z

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

On Tue, 2005-05-31 at 12:36 +0200, Pavel Machek wrote:
> Hi!
>
> > If we specify a swap device for swsusp using resume= kernel argument and
> > that device doesn't exist in the swap list, we end up calling
> > swsusp_free() before we have allocated pagedir_save. That causes us to
> > explode when trying to free it.
> >
> > Pavel, does that look right ?
>
> It looks like a workaround. We should not call swsusp_free in case
> device does not exists. Quick look did not reveal where the bug comes
> from, can you try to trace it?
> Pavel

Well, the bug comes from arch code calling swsusp_save() which fails,
then we call swsusp_free()

Ben.