RTPM allowing trailing newline in state_store()

RTPM allowing trailing newline in state_store()

[Daniel Gollub]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

hi,

is there a special way reserved for writing on power/state in the device
directories?
a simple echo {0,1,2,3} doesn't work, because of the trailing newline.
only with echo -n it works.
i was very confused about that... i needed two days to figure this out
:)
maybe it's a good idea to allow an value with \n  .. because other state
files like /sys/power/state also allows trailing newlines.

can you please give me a hint, if there is another special way to set a
single device in suspend. or is there a reason for ignoring trailing
newline?

thanks,
daniel

simple patch for allowing trailing newlines in state_strore in sysfs.c :

--- linux/drivers/base/power/sysfs.c.orig       2005-09-20
17:07:42.000000000 +0200
+++ linux/drivers/base/power/sysfs.c    2005-09-20 17:09:42.000000000
+0200
@@ -36,7 +36,7 @@ static ssize_t state_store(struct device
        int error = 0;
 
        state = simple_strtoul(buf, &rest, 10);
-       if (*rest)
+       if (*rest && *rest != '\n')
                return -EINVAL;
        if (state)
                error = dpm_runtime_suspend(dev, state);

_______________________________________________
linux-pm mailing list
linux-pm@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/linux-pm

[-- Attachment #2: SpamAssassinReport.txt --]
[-- Type: text/plain, Size: 1132 bytes --]

Spam detection software, running on the system "fire-1.osdl.org", has
identified this incoming email as possible spam.  The original message
has been attached to this so you can view it (if it isn't spam) or block
similar future email.  If you have any questions, see
the administrator of that system for details.

Content preview:  hi, is there a special way reserved for writing on
  power/state in the device directories? a simple echo {0,1,2,3} doesn't
  work, because of the trailing newline. only with echo -n it works. i
  was very confused about that... i needed two days to figure this out :)
  maybe it's a good idea to allow an value with \n .. because other state
  files like /sys/power/state also allows trailing newlines. [...] 

Content analysis details:   (6.0 points, 5.0 required)

 pts rule name              description
---- ---------------------- --------------------------------------------------
 2.0 OSDL_HIGH_ASCII_6      BODY: 6 high-ASCII characters in a row
 2.0 OSDL_HIGH_ASCII_7      BODY: 7 high-ASCII characters in a row
 2.0 OSDL_HIGH_ASCII_15     BODY: 15 or more high-ASCII characters in a row