Re: [RFC 2/3] Runtime PM support for named power states

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

Hi!

> Index: usb-2.6/drivers/pci/probe.c
> ===================================================================
> --- usb-2.6.orig/drivers/pci/probe.c
> +++ usb-2.6/drivers/pci/probe.c
> @@ -22,6 +22,54 @@ EXPORT_SYMBOL(pci_root_buses);
>  
>  LIST_HEAD(pci_devices);
>  
> +const char pci_name_D0[] = "D0";
> +const char pci_name_D1[] = "D1";
> +const char pci_name_D2[] = "D2";
> +const char pci_name_D3[] = "D3";

Why not "D3hot"? And what about "D3cold"?

> +/**
> + * pci_state_to_name -- return a static name string for a power state
> + * @state: power state to convert
> + */
> +const char *pci_state_to_name(pci_power_t state)
> +{
> +	static const char *(names[]) = {
> +		pci_name_D0, pci_name_D1, pci_name_D2,
> +		"D3hot", "D3cold", "Unknown"};

} should go on separate line.

> +	int i = (int __force) state;
> +
> +	if (i < 0 || i >= sizeof(names) / sizeof(names[0]))
> +		return "Error";

Why the "Unknown" in the array, then?

> @@ -109,6 +117,7 @@ struct pci_dev {
>  	pci_power_t     current_state;  /* Current operating state. In ACPI-speak,
>  					   this is D0-D3, D0 being fully functional,
>  					   and D3 being off. */
> +	const char	*(states[5]);	/* Names for supported states */

That constant looks strange here...
								Pavel
-- 
if you have sharp zaurus hardware you don't need... you know my address

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]