Re: [RFC 1/3] Runtime PM support for named power states

Greg KH
2005-10-02T21:45:58Z

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

On Sun, Oct 02, 2005 at 10:37:46PM +0200, Pavel Machek wrote:
> Hi!
>
> > Index: usb-2.6/drivers/base/power/sysfs.c
> > ===================================================================
> > --- usb-2.6.orig/drivers/base/power/sysfs.c
> > +++ usb-2.6/drivers/base/power/sysfs.c
> > @@ -3,12 +3,21 @@
> > */
> >
> > #include <linux/device.h>
> > +#include <linux/string.h>
> > #include "power.h"
> >
> > +const char pm_name_ON[] = "on";
> > +const char pm_name_SUSPEND[] = "suspend";
> > +EXPORT_SYMBOL_GPL(pm_name_ON);
> > +EXPORT_SYMBOL_GPL(pm_name_SUSPEND);
> > +
>
> Oops, I believe we still want non-GPL drivers to work correctly with
> our kernel...

For new interfaces? No, I do not think so. Remember, everything in the
driver model is marked this way today.

thanks,

greg k-h