Re: [RFC/RFT][PATCH 0/2] swsusp: improve freeing of memory

Pavel Machek
2005-11-09T23:19:30Z

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi!

> > If you want someone to test crypto swsusp, ask ast@domdv.de. But
> > removing that option is okay, too.
>
> And which one do you prefer?

Remove, I need something to encourage people to move reading/writing
of image to userland ;-).

> > I still miss those "a"s in "swap".
>
> Ahh, _these_ "a"s. OK, no problem, I'll add them (I didn't get it
> previously, sorry).

:-).

> > +void snapshot_pblist_set(struct pbe *pblist)
> > +{
> > + pagedir_nosave = pblist;
> > +}
....
> > If you really want to clean this up, swsusp_save should probably be
> >
> > int swsusp_save(struct pbe **pblist, int *nr_pages)
>
> Then I'll have to mess up with the assembly parts, which I'd like to avoid
> as long as reasonable, especially as far as it gets to the ppc one ...

No, I do not think you have to. Make swsusp_save() assign to
pagedir_nosave; that's okay. But swsusp_save is part of snapshot.c,
and assembly parts belong logically there, too, so you at least do not
export pagedir_nosave uglyness outside snapshot.c.
Pavel
--
Thanks, Sharp!