Re: [RFC/RFT][PATCH 0/2] swsusp: improve freeing of memory

Rafael J. Wysocki
2005-11-09T23:07:09Z

Hi,

On Wednesday, 9 of November 2005 22:04, Pavel Machek wrote:
> Hi!
>
> > > The patches are on top of 2.6.14-mm1 with the three additional patches of mine
> > > that went to Andrew after 2.6.14-mm1. For your convenience the whole
> > > series of patches is available at:
> > >
> > > http://www.sisk.pl/kernel/patches/2.6.14-mm1/
> > >
> > > as:
> > >
> > > swsusp-reduce-code-duplication.patch
> > > swsusp-improve-relocation.patch
> > > swsusp-rework-swsusp_suspend.patch
> > > swsusp-introduce-swap-map.patch
> > > swsusp-improve-freeing-memory.patch
> >
> > I got
> >
> > CC kernel/power/snapshot.o
> ...
> > kernel/power/snapshot.c:49: error: for each function it appears in.)
> >
> > I tried turning off HIGMEM, that got me rid of snapshot.c:49
> > problem. I killed nr_copy_pages from power.h. I tried suspending
> > twice, and it seems to work okay. I guess they are ready for lkml
> > testing...
>
> I put it under a bit heavier test (attached), and it survive for a
> hour. Looks good.

Great, thanks a lot. I've got two days of uptime with it now with several
suspend/resume cycles and some production work in between, so it
looks promising to me too.

BTW, the new USB suspend/resume behaves very well here. I haven't got any
problems with it so far, although it was under heavy stress in the early
phase of testing of my patches. Kudos to everyone involved.

Rafael