Re: [RFC/RFT][PATCH 0/2] swsusp: improve freeing of memory

Rafael J. Wysocki
2005-11-09T22:55:34Z

Hi,

On Wednesday, 9 of November 2005 15:30, Pavel Machek wrote:
> Hi!
>
> > The patches are on top of 2.6.14-mm1 with the three additional patches of mine
> > that went to Andrew after 2.6.14-mm1. For your convenience the whole
> > series of patches is available at:
> >
> > http://www.sisk.pl/kernel/patches/2.6.14-mm1/
> >
> > as:
> >
> > swsusp-reduce-code-duplication.patch
> > swsusp-improve-relocation.patch
> > swsusp-rework-swsusp_suspend.patch
> > swsusp-introduce-swap-map.patch
> > swsusp-improve-freeing-memory.patch
>
> I got
>
> CC kernel/power/snapshot.o
> kernel/power/snapshot.c:38: error: static declaration of
> 'nr_copy_pages' follows non-static declaration
> kernel/power/power.h:56: error: previous declaration of
> 'nr_copy_pages' was here
> kernel/power/snapshot.c: In function 'count_highmem_pages':
> kernel/power/snapshot.c:49: error: 'zone_pfn' undeclared (first use in
> this function)
> kernel/power/snapshot.c:49: error: (Each undeclared identifier is
> reported only once
> kernel/power/snapshot.c:49: error: for each function it appears in.)
>
> I tried turning off HIGMEM, that got me rid of snapshot.c:49
> problem. I killed nr_copy_pages from power.h. I tried suspending
> twice, and it seems to work okay.

Thanks a lot for testing! The compilation errors mean I should have tried
to compile it on i386. Sorry for the trouble.

> I guess they are ready for lkml testing...

Well, they'll go there after I get rid of the compilation problems and
make the changes you have suggested. Still I'm afraid they won't
get enough testing unless they go into -mm for some time ...

Rafael