Re: [RFC/RFT][PATCH 0/2] swsusp: improve freeing of memory

Pavel Machek
2005-11-09T21:04:02Z

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

Hi!

> > The patches are on top of 2.6.14-mm1 with the three additional patches of mine
> > that went to Andrew after 2.6.14-mm1. For your convenience the whole
> > series of patches is available at:
> >
> > http://www.sisk.pl/kernel/patches/2.6.14-mm1/
> >
> > as:
> >
> > swsusp-reduce-code-duplication.patch
> > swsusp-improve-relocation.patch
> > swsusp-rework-swsusp_suspend.patch
> > swsusp-introduce-swap-map.patch
> > swsusp-improve-freeing-memory.patch
>
> I got
>
> CC kernel/power/snapshot.o
...
> kernel/power/snapshot.c:49: error: for each function it appears in.)
>
> I tried turning off HIGMEM, that got me rid of snapshot.c:49
> problem. I killed nr_copy_pages from power.h. I tried suspending
> twice, and it seems to work okay. I guess they are ready for lkml
> testing...

I put it under a bit heavier test (attached), and it survive for a
hour. Looks good.

Pavel
#!/bin/bash
SW3=false
if $SW3 ; then
swapoff /dev/hda1
cat /dev/zero | head -c 4096 > /dev/hda1
else
swapon -a
echo -n reboot > /sys/power/disk
fi

(
while true ; do
echo "Suspending machine"
if $SW3; then
/tmp/swsusp /dev/hda1 -s -b
else
echo -n disk > /sys/power/state
fi

sleep 30
done
) &
cd /data/l
cp -a linux-good linux-fscktest
cd /data/l/linux-fscktest
make clean
time make -j 10

--
Thanks, Sharp!