Re: [patch] pm: fix runtime powermanagement's /sys interface

Pavel Machek
2005-12-27T22:05:33Z

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Hi!

> > static ssize_t state_show(struct device * dev, struct device_attribute *attr, char * buf)
> > {
> > - return sprintf(buf, "%u\n", dev->power.power_state.event);
> > + if (dev->power.power_state.event)
> > + return sprintf(buf, "suspend\n");
> > + else
> > + return sprintf(buf, "on\n");
> > }
>
> Are you sure that having only 2 options (suspend/on) is enough at the
> core level? I could envision having more levels, like "poweroff", etc?

Note that interface is 0/2, currently, so this is improvement :-).

One day, when we find device that needs it, we may want to add more
states. I don't know about such device currently.

Pavel
--
Thanks, Sharp!