Re: Re: [RFC][PATCH -mm] swsusp userland interface: additional ioctl

Greg KH
2006-01-30T04:54:48Z

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Mon, Jan 30, 2006 at 12:06:47AM +0100, Pavel Machek wrote:
> Hi!
>
> > > > The appended patch provides an additional ioctl() for the swsusp userland
> > > > interface that will allow the suspending and/or resuming utilities to change
> > > > the kernel log level at the time of suspend/resume (or even set it to 0 if
> > > > they are going to use some frame buffer graphics etc.).
> > >
> > > klogd can already change loglevel... It should be possible to use that
> > > to silence suspend, no?
> >
> > Well, no. Currently the kernel changes the log level to 10 unconditionally
> > in pm_prepare_console() (that's the reason for the patch, BTW).
>
> Can we just kill that log-level setting? It may have been useful in
> the past, but I do not think it has right to live any more.

Yes, change that, don't create another interface to the kernel where
there is already one.

thanks,

greg k-h