public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Linux PM <linux-pm@osdl.org>
Subject: Re: Re: [RFC][PATCH -mm] swsusp userland interface: additional ioctl
Date: Sun, 29 Jan 2006 20:54:48 -0800	[thread overview]
Message-ID: <20060130045448.GE13244@kroah.com> (raw)
In-Reply-To: <20060129230647.GE2318@elf.ucw.cz>

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Mon, Jan 30, 2006 at 12:06:47AM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > The appended patch provides an additional ioctl() for the swsusp userland
> > > > interface that will allow the suspending and/or resuming utilities to change
> > > > the kernel log level at the time of suspend/resume (or even set it to 0 if
> > > > they are going to use some frame buffer graphics etc.).
> > > 
> > > klogd can already change loglevel... It should be possible to use that
> > > to silence suspend, no?
> > 
> > Well, no.  Currently the kernel changes the log level to 10 unconditionally
> > in pm_prepare_console() (that's the reason for the patch, BTW).
> 
> Can we just kill that log-level setting? It may have been useful in
> the past, but I do not think it has right to live any more.

Yes, change that, don't create another interface to the kernel where
there is already one.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2006-01-30  4:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-29 21:56 [RFC][PATCH -mm] swsusp userland interface: additional ioctl Rafael J. Wysocki
2006-01-29 21:57 ` Pavel Machek
2006-01-29 22:46   ` Rafael J. Wysocki
2006-01-29 23:06     ` Pavel Machek
2006-01-30  4:54       ` Greg KH [this message]
2006-01-30 21:15       ` Rafael J. Wysocki
2006-01-30 21:59         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060130045448.GE13244@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-pm@osdl.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox