* [RFC] pm_prepare_console in drivers/macintosh/via-pmu.c
@ 2006-02-01 7:31 Rafael J. Wysocki
2006-02-01 22:36 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2006-02-01 7:31 UTC (permalink / raw)
To: Linux PM, Benjamin Herrenschmidt
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
Hi,
The drivers/macintosh/via-pmu.c driver is the only user of pm_prepare_console()
and pm_restore_console() calls outside of kernel/power. If it is going to stay like
that we should move the new #ifdef around the declarations of
pm_prepare_console() and pm_restore_console() as well as the definition
of SUSPEND_CONSOLE from kernel/power/power.h to include/linux/suspend.h,
unless CONFIG_VT and CONFIG_VT_CONSOLE are always set on Macs.
Please advise.
Rafael
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] pm_prepare_console in drivers/macintosh/via-pmu.c
2006-02-01 7:31 [RFC] pm_prepare_console in drivers/macintosh/via-pmu.c Rafael J. Wysocki
@ 2006-02-01 22:36 ` Benjamin Herrenschmidt
2006-02-01 23:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2006-02-01 22:36 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Wed, 2006-02-01 at 08:31 +0100, Rafael J. Wysocki wrote:
> Hi,
>
> The drivers/macintosh/via-pmu.c driver is the only user of pm_prepare_console()
> and pm_restore_console() calls outside of kernel/power. If it is going to stay like
> that we should move the new #ifdef around the declarations of
> pm_prepare_console() and pm_restore_console() as well as the definition
> of SUSPEND_CONSOLE from kernel/power/power.h to include/linux/suspend.h,
> unless CONFIG_VT and CONFIG_VT_CONSOLE are always set on Macs.
They should always be set...
Ben.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] pm_prepare_console in drivers/macintosh/via-pmu.c
2006-02-01 22:36 ` Benjamin Herrenschmidt
@ 2006-02-01 23:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2006-02-01 23:08 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Linux PM
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Wednesday 01 February 2006 23:36, Benjamin Herrenschmidt wrote:
> On Wed, 2006-02-01 at 08:31 +0100, Rafael J. Wysocki wrote:
> > Hi,
> >
> > The drivers/macintosh/via-pmu.c driver is the only user of pm_prepare_console()
> > and pm_restore_console() calls outside of kernel/power. If it is going to stay like
> > that we should move the new #ifdef around the declarations of
> > pm_prepare_console() and pm_restore_console() as well as the definition
> > of SUSPEND_CONSOLE from kernel/power/power.h to include/linux/suspend.h,
> > unless CONFIG_VT and CONFIG_VT_CONSOLE are always set on Macs.
>
> They should always be set...
So no changes are needed. :-)
Thanks,
Rafael
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-01 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-01 7:31 [RFC] pm_prepare_console in drivers/macintosh/via-pmu.c Rafael J. Wysocki
2006-02-01 22:36 ` Benjamin Herrenschmidt
2006-02-01 23:08 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox