public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
	linux-pm@osdl.org
Subject: Re: [PATCH 5/5] [pci pm] Make pci_choose_state() use the real device state requested
Date: Sat, 18 Feb 2006 16:58:36 +0100	[thread overview]
Message-ID: <20060218155836.GF5658@openzaurus.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.50.0602171759190.30811-100000@monsoon.he.net>

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi!

>  	case PM_EVENT_FREEZE:
>  	case PM_EVENT_SUSPEND:
> -		return PCI_D3hot;
> +		if (msg.state && msg.state <= PCI_D3hot)
> +			state = msg.state;
> +		break;
>  	default:

Silently ignores wrong value passed-in by user. Not nice...
				Pavel

-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2006-02-18 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-18  2:03 [PATCH 5/5] [pci pm] Make pci_choose_state() use the real device state requested Patrick Mochel
2006-02-18 15:58 ` Pavel Machek [this message]
2006-02-20  0:09   ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060218155836.GF5658@openzaurus.ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@osdl.org \
    --cc=mochel@digitalimplant.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox