From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-pm@osdl.org
Subject: Re: [PATCH 3/5] [pm] Respect the actual device power states in sysfs interface
Date: Mon, 20 Feb 2006 01:09:07 +0100 [thread overview]
Message-ID: <20060220000907.GE15608@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.50.0602191557520.8676-100000@monsoon.he.net>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Ne 19-02-06 15:59:25, Patrick Mochel wrote:
>
> On Sat, 18 Feb 2006, Pavel Machek wrote:
>
> > Hi!
> >
> > > Fix the per-device state file to respect the actual state that
> > > is reported by the device, or written to the file.
> >
> > Can we let "state" file die? You actually suggested that at one point.
> >
> > I do not think passing states in u32 is good idea. New interface that passes
> > state as string would probably be better.
>
> Yup, in the future that will be better. For now, let's work with what we
> got and fix 2.6.16 to be compatible with previous versions..
It already is. It accepts "0" and "2" and "3". That's all values that
used to work. Other values used to trigger BUG() in pci.c (and we do
not want to re-introduce _that_ behaviour, right?).
If you add u32 into pm_message_t, it will be impossible to remove in
future.
Pavel
--
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2006-02-20 0:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 2:03 [PATCH 3/5] [pm] Respect the actual device power states in sysfs interface Patrick Mochel
2006-02-18 15:55 ` Pavel Machek
2006-02-19 23:59 ` Patrick Mochel
2006-02-20 0:09 ` Pavel Machek [this message]
2006-02-20 0:17 ` Patrick Mochel
2006-02-20 0:20 ` Pavel Machek
2006-02-20 0:36 ` Patrick Mochel
2006-02-20 0:41 ` Pavel Machek
2006-02-20 17:55 ` Patrick Mochel
2006-02-20 17:58 ` Pavel Machek
2006-02-20 18:08 ` Patrick Mochel
2006-02-20 18:10 ` [linux-pm] " Pavel Machek
2006-02-20 0:46 ` Greg KH
2006-02-20 17:58 ` [linux-pm] " Patrick Mochel
2006-02-20 22:04 ` Greg KH
2006-02-21 1:09 ` Patrick Mochel
2006-02-21 10:57 ` Pavel Machek
2006-02-21 11:12 ` Patrick Mochel
2006-02-21 11:25 ` Pavel Machek
2006-02-27 19:06 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220000907.GE15608@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=mochel@digitalimplant.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox