From: Greg KH <greg@kroah.com>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: akpm@osdl.org, linux-pm@osdl.org, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in).
Date: Tue, 21 Feb 2006 09:50:43 -0800 [thread overview]
Message-ID: <20060221175043.GB23054@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.50.0602201652430.21145-100000@monsoon.he.net>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Mon, Feb 20, 2006 at 04:55:37PM -0800, Patrick Mochel wrote:
>
> Signed-off-by: Patrick Mochel <mochel@linux.intel.com>
>
> ---
>
> include/linux/pm.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> applies-to: 55ce8c6305fc70b1b544ce7365abd6054e9b5f61
> 7af37561812f4599841ade4abee067b808b40054
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 5be87ba..a7324ea 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -140,6 +140,7 @@ struct device;
>
> typedef struct pm_message {
> int event;
> + u32 state;
Can we _please_ make this an enumerated type that is able to be
type-checked by sparse? A "raw" u32 is not a good thing to have here.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2006-02-21 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 0:55 [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in) Patrick Mochel
2006-02-21 17:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060221175043.GB23054@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=mochel@digitalimplant.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox