* [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in).
@ 2006-02-21 0:55 Patrick Mochel
2006-02-21 17:50 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Mochel @ 2006-02-21 0:55 UTC (permalink / raw)
To: greg, akpm, torvalds; +Cc: linux-kernel, linux-pm
Signed-off-by: Patrick Mochel <mochel@linux.intel.com>
---
include/linux/pm.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applies-to: 55ce8c6305fc70b1b544ce7365abd6054e9b5f61
7af37561812f4599841ade4abee067b808b40054
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 5be87ba..a7324ea 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -140,6 +140,7 @@ struct device;
typedef struct pm_message {
int event;
+ u32 state;
} pm_message_t;
/*
---
0.99.9.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in).
2006-02-21 0:55 [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in) Patrick Mochel
@ 2006-02-21 17:50 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2006-02-21 17:50 UTC (permalink / raw)
To: Patrick Mochel; +Cc: akpm, linux-pm, torvalds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Mon, Feb 20, 2006 at 04:55:37PM -0800, Patrick Mochel wrote:
>
> Signed-off-by: Patrick Mochel <mochel@linux.intel.com>
>
> ---
>
> include/linux/pm.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> applies-to: 55ce8c6305fc70b1b544ce7365abd6054e9b5f61
> 7af37561812f4599841ade4abee067b808b40054
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 5be87ba..a7324ea 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -140,6 +140,7 @@ struct device;
>
> typedef struct pm_message {
> int event;
> + u32 state;
Can we _please_ make this an enumerated type that is able to be
type-checked by sparse? A "raw" u32 is not a good thing to have here.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-21 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-21 0:55 [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in) Patrick Mochel
2006-02-21 17:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox