From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: linux-pm@lists.osdl.org
Cc: linux-pm@osdl.org
Subject: Re: [PATCH] suspend.c: make sure stdin, stdout and stderr are open
Date: Fri, 24 Mar 2006 21:36:55 +0100 [thread overview]
Message-ID: <200603242136.56180.rjw@sisk.pl> (raw)
In-Reply-To: <200603242013.48811.stefan@loplof.de>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Hi,
On Friday 24 March 2006 20:13, Stefan Rompf wrote:
> recently I patched my 2.6.16 kernel to use uswsusp. Nice work, but when I
> installed /usr/local/sbin/suspend into the Suse 9.3 powermanagement scripts,
> I've stumbled over a bad interaction: powersaved closes all filedescriptors
> before calling scripts. suspend then opens snapshot and swap device,
> allocating file descriptors 0 and 1, but printfs() afterwards. Luckily, I did
> not lose any data.
>
> For robustness, suspend must make sure that these fds are open. Simple patch
> to achieve this is attached. It loses the descriptors, but I don't think
> that's an issue for the short running program.
Thanks a lot for the patch, I'll have a look at it shortly.
BTW, it follows from what you said that you compiled suspend on SuSE 9.3.
Was it on i386?
Rafael
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2006-03-24 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 19:13 [PATCH] suspend.c: make sure stdin, stdout and stderr are open Stefan Rompf
2006-03-24 20:36 ` Rafael J. Wysocki [this message]
2006-03-24 22:55 ` Rafael J. Wysocki
2006-03-25 8:20 ` Stefan Rompf
2006-03-25 10:54 ` Rafael J. Wysocki
2006-04-10 6:58 ` Stefan Seyfried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603242136.56180.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-pm@lists.osdl.org \
--cc=linux-pm@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox