Re: [patch/rft 2.6.17-rc2] swsusp resume must not device_suspend()

Pavel Machek
2006-04-27T10:54:47Z

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi!

> > It seems to me that the right solution might be for these usb devices to
> > treat a resume from a freeze as an indication that hardware should be reset.
>
> I don't much like that model. It creates more special cases in drivers (not
> just USB), and redefines the "freeze" thing to be more than just "quiescede".
> Every special case that gets added is a breeding ground for more bugs.
>
> Also, what about the resume-from-freeze that _every_ device does during swsusp
> suspend? The kernel is still resuming every device, not just the ones needed
> to write the suspend partition.

It is quite hard to tell which devices are needed for write... Plus
only resuming some drivers would only hide the bugs in drivers not
needed for write, and speedup suspend a tiny bit. Too little benefit
for more complex code, I'd say.
Pavel
--
Thanks, Sharp!

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]