Re: [patch/rft 2.6.17-rc2] swsusp resume must not device_suspend()

David Brownell
2006-04-26T21:31:43Z

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On Wednesday 26 April 2006 4:26 am, Rafael J. Wysocki wrote:
> On Wednesday 26 April 2006 00:56, David Brownell wrote:

> > But it's not the root cause of the problem either. The same problem appears if
> > the device holding the resume partition gets forced into this "broken suspend"
> > state.
>
> Well, IMO the state may or may not be broken depending on the device,
> so we should not assume it will always be broken.

Not so. See my previous emails. The "broken suspend" state is broken
by definition. Maybe you're referring to a different issue ... whether
or not its driver would notice that bug.

> > Now, if you have specific examples of things that shouldn't be reset, that
> > could be interesting.
>
> The resume device and friends (ie. controller, bus, etc.).

Bad answer. If its driver would notice, then it must be reset.
And if the driver wouldn't notice, resetting won't matter.

There's still no example of a device that should not be reset
(a second time).

- Dave

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]