Re: [PATCH 2/2] Fix console handling during suspend/resume

[Pavel Machek <pavel@suse.cz>]

On St 14-06-06 15:38:39, Linus Torvalds wrote:
> 
> 
> On Wed, 14 Jun 2006, Peter Jones wrote:
> 
> > On Thu, 2006-06-15 at 00:12 +0200, Pavel Machek wrote:
> > > 
> > > if (network_driver_suspended)
> > > 	drop_message_on_the_floor() 
> > 
> > I think we have the same problems with e.g. fbcon .
> 
> We have the same problem with EVERY SINGLE CONSOLE DEVICE, and we don't 
> always even know which chip is the device (ie the VGA console simply 
> doesn't even care).
> 
> Which is why my solution really is the right one.

Actually, no, it is not.

It happens to be almost okay for s2ram, but it will mean no messages
for suspend to disk... and that is bad.

Console subsystem should be stopped when console device is stopped,
and restarted when console device is restarted.

If that is not practical, it should be stopped when all the other
devices are stopped, and resumed when all the other devices are
resumed. Currently, pm_restore_console is not called when devices are
resumed before writing to disk (in s2disk case).

pm_prepare/restore_console would need to be split to two function to
DTRT with s2disk.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html