From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 2/2] Fix console handling during suspend/resume Date: Thu, 15 Jun 2006 01:32:33 +0200 Message-ID: <20060614233233.GA21135@elf.ucw.cz> References: <20060614224436.GF7751@elf.ucw.cz> <200606150102.53961.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <200606150102.53961.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: "Rafael J. Wysocki" Cc: Linus Torvalds , linux-pm@lists.osdl.org List-Id: linux-pm@vger.kernel.org Hi! > > Actually, no, it is not. > > = > > It happens to be almost okay for s2ram, but it will mean no messages > > for suspend to disk... and that is bad. > > = > > Console subsystem should be stopped when console device is stopped, > > and restarted when console device is restarted. > = > Well, I don't know. In ususpend we only use pm_prepare/restore_console() > during resume and we can live without that at all. Linus has examples why console stopping is neccessary (netconsole case)... so I do not think we can live without that. Cleanest solution would be if console driver simply responded to device_suspend() and do all neccessary stuff... Pavel -- = (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html