Re: [PATCH 2/2] Fix console handling during suspend/resume

Nigel Cunningham
2006-07-06T07:15:30Z

[-- Attachment #1.1: Type: text/plain, Size: 884 bytes --]

Hi.

On Thursday 06 July 2006 11:52, Nigel Cunningham wrote:
> Hi.
>
> On Thursday 06 July 2006 11:15, Pavel Machek wrote:
> > I have seen that before: Atomic snapshot used fpu copy in some wrong
> > variants. Symptom was exactly that -- elevated preempt count --
> > because fpu copy routine elevated it, then copied the task struct.
> >
> > But I thought we solved that problem...?
>
> We did. We don't use memcpy for precisely that reason. 3DNOW memcpy was one
> of the problem children. This would be a different creature though,
> wouldn't it?

Hmm. Aparently we had a parting of ways on this at some point. Memcpy is being
used by swsusp, and it has been used since before 2.6.12-rc1. (This is when
doing the atomic copy, not resuming).

Regards,

Nigel
--
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]