Re: [PATCH 2/2] Fix console handling during suspend/resume

Nigel Cunningham
2006-06-16T02:53:08Z

[-- Attachment #1.1: Type: text/plain, Size: 919 bytes --]

Hi.

On Friday 16 June 2006 11:31, Benjamin Herrenschmidt wrote:
> > Why are people being dense and stupid? I told you in the very first
> > explanation that the IO state isn't suspended by "save_state()".
> >
> > "save_state()" would not disable the device. It would not disable the
> > queues. The device would remain usable, and 100% functional.
>
> But what is the point ? What is the relevance of a state saved if it can
> be made invalid right away by processing of IOs ? I can save state at
> any time and suspend 2 hours later, how relevant that state is ? Why not
> save the state at boot and re-use it later ? Doesn't make sense to me :)

That would be right for some drivers, but not for all (scsi request ids, eg).
The knowledge of what to do needs to be in the driver.

Regards,

Nigel
--
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]