Re: [PATCH 2/2] Fix console handling during suspend/resume

Pavel Machek
2006-06-24T21:33:14Z

Hi!

> > I've very rarely seen drivers trying to do _anything_ to work around STD
> > specific issues. I think Pavel and David are right there... suspend() is
> > mostly written for STR and that way happens to work with STD...
>
> I don't think I've used those words ... :)
>
> The PRETHAW patches (which I'll forward for MM after I retest against
> the latest GIT tree) are proof that the suspend-to-disk resume paths
> actually **DON'T** just happen to work in all cases. Which does pretty
> much show that the STD stuff (FREEZE etc) was an afterthought.

Well... lets say that PRETHAW patches were only introduced _years_
after swsusp started working -- so it is not _that_ important.

Yes, you are right, in resume path, during s2ram you can assume
hardware was powered on, while in s2disk case hardware might have been
already initialized or not.

In practice, it is not a big deal.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html