Re: [PATCH 2/2] Fix console handling during suspend/resume

Benjamin Herrenschmidt
2006-06-16T01:03:36Z

On Wed, 2006-06-14 at 18:26 -0400, Peter Jones wrote:
> On Thu, 2006-06-15 at 00:12 +0200, Pavel Machek wrote:
> > Hi!
> >
> > > > > The debugging patch helped me figure out a number of the problems (and
> > > > > even more problems that then didn't actually make any difference once I
> > > > > started getting things working ;)
> > > > >
> > > > > And the console fixes is apparently what got things working in SMP mode.
> > > >
> > > > It works for some people _without_ that console fix.
> > >
> > > Yes. It worked for me in UP and with several drivers removed without the
> > > console fix. It didn't work for me when I did fancier stuff, netconsole in
> > > particular ;/
> >
> > I guess I'd much rather see
> >
> > if (network_driver_suspended)
> > drop_message_on_the_floor()
>
> I think we have the same problems with e.g. fbcon .

fbcon has an interface to stop all access to the physical framebuffer.
It's called fb_set_suspend() and is meant to be called by the fbdev when
it's suspended.

Ben